Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel ratio validation fails #170

Open
igorti opened this issue Jun 26, 2017 · 2 comments
Open

Pixel ratio validation fails #170

igorti opened this issue Jun 26, 2017 · 2 comments

Comments

@igorti
Copy link

igorti commented Jun 26, 2017

When dealing with imagery from far up north(like Norway) pixel ratio can well exceed boundaries defined in this code.

Is there any background to why chosen max value is 2? For the imagery that I'm having problem with(can provide example if needed) ratio is over 3, but it seems to be a perfectly valid geotiff.

cc @GretaCB

@igorti
Copy link
Author

igorti commented Mar 29, 2018

Can anyone comment on this? @flippmoke?

@GretaCB
Copy link
Contributor

GretaCB commented Mar 29, 2018

Hi @igorti , thanks for the ping and pardon the delay. The specific ratio buffer was added here #98 (comment) .

Would definitely be interested in your example, and it would be great for mapnik-omnivore to support parts of the globe with slightly larger pixel ratio. Mind spinning up a testcase PR?


For anyone following along, this relates to the gdalDatasource.geoTransform array, which we're using via node-gdal in this module.

adfGeoTransform[0] /* top left x */
adfGeoTransform[1] /* w-e pixel resolution */
adfGeoTransform[2] /* 0 */
adfGeoTransform[3] /* top left y */
adfGeoTransform[4] /* 0 */
adfGeoTransform[5] /* n-s pixel resolution (negative value) */

perliedman added a commit to perliedman/mapnik-omnivore that referenced this issue May 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants