Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to protozero #143

Open
springmeyer opened this issue Nov 21, 2017 · 0 comments
Open

Port to protozero #143

springmeyer opened this issue Nov 21, 2017 · 0 comments

Comments

@springmeyer
Copy link
Contributor

We should port the code to protozero because:

  • it would make the code easier to build: no protoc to run, no pre-compiled library to link
  • it would make the build system easier to maintain and easier to update deps
  • it would make the code potentially higher performance

The downside to protozero is that it makes it slightly more work when you want to update the protobuf scheme. However, I think this is a fine tradeoff since the schema here for glyphs has not changed frequently so far.

This in my mind is low urgency, but a nice to have and a good starter task for someone interested in learning and using protozero more.

/cc for visibility @kkaefer @ChrisLoer @mapbox/core-tech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants