Remove use of prepublish in recommended setup #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The recommendation of `prepublish` here was to help ensure the bundled deps tree is correct. But `prepublish` also runs during install per npm/npm#10074. So, let's avoid the confusion and potential gochas of different npm versions by not recommending this hook.
springmeyer
pushed a commit
that referenced
this pull request
Sep 7, 2017
springmeyer
pushed a commit
to mapnik/node-mapnik
that referenced
this pull request
Sep 7, 2017
springmeyer
added a commit
to mapbox/node-zipfile
that referenced
this pull request
Sep 7, 2017
springmeyer
added a commit
to mapbox/mbtiles-geostats
that referenced
this pull request
Sep 7, 2017
springmeyer
added a commit
to mapbox/node-cpp-skel
that referenced
this pull request
Sep 7, 2017
springmeyer
added a commit
to mapbox/node-fontnik
that referenced
this pull request
Sep 7, 2017
rafatower
pushed a commit
to CartoDB/node-mapnik
that referenced
this pull request
Jan 5, 2018
Algunenano
pushed a commit
to Algunenano/node-mapnik
that referenced
this pull request
Mar 19, 2018
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Remove use of prepublish in recommended setup
hyj1991
pushed a commit
to X-Profiler/node-pre-gyp
that referenced
this pull request
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recommendation of
prepublishhere was to help ensure the bundled deps tree is correct before publishing (because sadly npm does not do this for us: npm/npm#5929).But
prepublishalso runs during install per npm/npm#10074 and https://github.com/npm/npm/blob/latest/CHANGELOG.md#new-prepare-script-prepublish-deprecated-breaking. So, let's avoid the confusion and potential gochas of different npm versions by not recommending this hook.refs https://github.com/springmeyer/bundle-dedupe-testcase a testcase demonstrated a problem with
npm lstriggering an error onnpm installdue to a deduping bug in npm v3.x