Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update changelog for pending release #833

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benmccann
Copy link
Contributor

No description provided.

@benmccann benmccann force-pushed the changelog branch 3 times, most recently from 6e85df2 to 6ac39c3 Compare July 3, 2024 12:48
@cclauss
Copy link
Collaborator

cclauss commented Jul 3, 2024

I think our changelog and readme should both state that we will attempt to track with https://github.com/nodejs/release#release-schedule and on a rolling basis we will not support Node.js versions that have fallen off that list.

In the changelog, let's put dependency upgrades after all other changes so that the document is easier to scan. Dependencies should appear in alphabetical order for readability reasons.

Please simplify https://github.com/mapbox/node-pre-gyp/blob/master/README.md#appveyor-automation to point readers to:

  1. https://ci.appveyor.com/project/Mapbox/node-pre-gyp/history
  2. https://github.com/mapbox/node-pre-gyp/blob/master/appveyor.yml
  3. http://www.appveyor.com/docs/appveyor-yml

Please remove https://github.com/mapbox/node-pre-gyp/blob/master/README.md#travis-automation and instead briefly describe how to find our GitHub Actions and their test results.

Thanks much!!

@benmccann
Copy link
Contributor Author

I think our changelog and readme should both state that we will attempt to track with https://github.com/nodejs/release#release-schedule and on a rolling basis we will not support Node.js versions that have fallen off that list.

Done

In the changelog, let's put dependency upgrades after all other changes so that the document is easier to scan. Dependencies should appear in alphabetical order for readability reasons.

Done

Please simplify https://github.com/mapbox/node-pre-gyp/blob/master/README.md#appveyor-automation ...

I will leave the readme updates for someone who is more familiar with the details as I don't feel I would do a good job updating these sections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants