-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prebuilt: add electron 6.0.0 #1195
Conversation
I filed a separate issue (#1197) for the failing Travis job, as it seems to be a preexisting issue that isn't caused by these changes. |
Thanks for fixing the tests @kewde ! |
@kewde (or anyone else) - is there anything else needed from me before this can be merged? |
Are there any plans on doing a release with this soon? Electron 6 support would be great for my project. Thanks |
+1 @kewde would be great to have this merged! |
👍 thanks all - merging this in, and will publish as 4.0.10 @kewde noticing some missing changelog updates for 4.0.8 and 4.0.9 - any chance you could follow up with an update there? Thanks! |
FYI - this will go out in 4.1.0, not 4.0.10, as there are some other changes in master that warrant a minor! |
|
Awesome, thanks all! |
This adds support for Electron 6.0.0. I used the same technique as #1160 and #1180.
Electron 6.0.0 was released on 7/30/2019.
https://electronjs.org/releases/stable#release-notes-for-v600