Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/performance improvements #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Feature/performance improvements #61

wants to merge 2 commits into from

Conversation

symbyte
Copy link
Contributor

@symbyte symbyte commented Dec 4, 2017

speeds up shp writing by an order of magnitude

@sheindel
Copy link
Contributor

Hi @symbyte! Thanks for contributing to the project.

My understanding is that forEach isn't nearly as slow in todays browsers as it used to be in years gone by. Do you think this still has value for the project? Have you learned any other better techniques since you opened this PR? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@symbyte @sheindel