Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options, multipolygon & types, tree shake, deps #96

Merged
merged 26 commits into from
Aug 21, 2023
Merged

Add options, multipolygon & types, tree shake, deps #96

merged 26 commits into from
Aug 21, 2023

Conversation

charlieforward9
Copy link
Contributor

@charlieforward9 charlieforward9 commented Aug 18, 2023 •
edited
Loading

Rebooting a 7 year stale file converter.
fix #59, fix #68, fix #73 , fix #74, fix #88
close #57, close #84, close #90, close #92
opened #97

charlieforward9 and others added 16 commits August 16, 2023 17:02
@charlieforward9
upgrade versions
bc5384d
@charlieforward9
name of ZIP set to folder name
4afcf77
@charlieforward9
Clean Geojson to take the geometries directly.
2c3e5e0 
Add support for multipolygon
@charlieforward9
Merge pull request #1 from Agriculture-Intelligence:minimal_upgrades
e5bb49f 
Minimal_upgrades
@charlieforward9
fix: ERROR: Delete of a bare identifier cannot be used with the "esm"…
e267b8f 
… output format due to strict mode
@charlieforward9
Merge pull request #2 from Agriculture-Intelligence/minimal_upgrades
b07a2e2 
fix: ERROR: Delete of a bare identifier cannot be used with the "esm"…
@charlieforward9
fix: restricting runtime env to browser
440611b
@charlieforward9
Merge pull request #3 from Agriculture-Intelligence:minimal_upgrades
5268fc5 
Minimal_upgrades
@charlieforward9
fix: designate output type
095eecc
@charlieforward9
Merge pull request #4 from Agriculture-Intelligence/minimal_upgrades
abda746 
fix: designate output type
@charlieforward9
fix: async await before download
a02e093
@charlieforward9
Merge pull request #5 from Agriculture-Intelligence/minimal_upgrades
93f5ab3 
fix: async await before download
@charlieforward9
feat: dist folder, with type defs
c99511c
@charlieforward9
Merge pull request #6 from Agriculture-Intelligence/minimal_upgrades
7c6063e 
feat: dist folder, with type defs
@charlieforward9
fix: explicitly add typings to package
b4f5d34
@charlieforward9
Merge pull request #7 from Agriculture-Intelligence/minimal_upgrades
4068f5a 
fix: explicitly add typings to package
charlieforward9
charlieforward9 commented Aug 18, 2023
View reviewed changes
src/zip.js Outdated Show resolved Hide resolved
@charlieforward9 charlieforward9 changed the title deps, #84, #90, typescript declaration file, auto download deps, options: filename, multipolygon, .d.ts, browser only downgrade (easy fix?) Aug 18, 2023
@charlieforward9 charlieforward9 mentioned this pull request Aug 19, 2023
Closed
@charlieforward9
Copy link
Contributor Author

charlieforward9 commented Aug 21, 2023 •
edited
Loading

@sheindel

If we can make these changes I feel more confident pulling your PR into the main shp-write repo. Mapbox let me take it over

Good time to wrap this one up too!

@sheindel sheindel merged commit 4146e58 into mapbox:master Aug 21, 2023
@charlieforward9 charlieforward9 changed the title deps, options: filename, multipolygon, .d.ts, browser only downgrade (easy fix?) deps, improved function options, multipolygon, types, depricate download function to browser only functionality. Aug 21, 2023
@charlieforward9 charlieforward9 changed the title deps, improved function options, multipolygon, types, depricate download function to browser only functionality. deps, improved function options, multipolygon, types, depricate download api. Aug 21, 2023
@charlieforward9 charlieforward9 changed the title deps, improved function options, multipolygon, types, depricate download api. deps, improved function options, multipolygon, types, tree shake. Aug 21, 2023
@charlieforward9 charlieforward9 changed the title deps, improved function options, multipolygon, types, tree shake. deps, improved options, add multipolygon & types, tree shake. Aug 21, 2023
@charlieforward9 charlieforward9 changed the title deps, improved options, add multipolygon & types, tree shake. Add options, multipolygon & types, tree shake, deps Aug 21, 2023
This was referenced Aug 21, 2023
Closed
Closed
Closed
Closed
Closed
@charlieforward9 charlieforward9 mentioned this pull request May 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheindel sheindel sheindel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@charlieforward9 @sheindel