Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use libnu mason dependency instead vendored src #61

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axrj
Copy link
Contributor

@axrj axrj commented Jul 26, 2022

make test fails with missing symbol called error on mac with both main and the PR branch equally. tests pass on CI though.

Todo:

  • Test with api-vectortiles
  • Maybe check test failure on mac.

@sofiapag
Copy link
Contributor

sofiapag commented Jul 28, 2022

TBD - from slack convo
What does make test do that is different from Travis builds?
Which missing symbol is missing on main? It could be a symbol which is undefined but not used in shaving, in which case it would be ok.

@axrj
Copy link
Contributor Author

axrj commented Jul 28, 2022

ah.
symbol not found in flat namespace '__ZTVN4mbgl12LayerFactoryE'
basically mbgl.LayerFactory
I don't think this is used anywhere but a reference is being compiled on darwin platform. Not sure where yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SPIKE] Revisit vendoring, in favor of adding mason dependency
2 participants