-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ignore for other IDEs and add ignore for docs/.venv/ #4074
Conversation
Are you okay with my plan? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I'm curious what the CMake project would look like.
Note that Qbs can also generate Visual Studio project files (I haven't tested it) and that there is a Qbs extension for VS Code. So I think Qbs is quite available (though not sure about CLion or Xcode).
.gitignore
Outdated
*.qbs.user* | ||
*.pro.user.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see why we would need to ignore pro files again. You're not going to add back a qmake project, are you?
.gitignore
Outdated
*.creator.* | ||
*.autosave | ||
*.pro.user | ||
*.qbs.user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be covered by the existing *.qbs.user*
ignore rule, right?
.gitignore
Outdated
@@ -7,8 +7,30 @@ default/ | |||
# Mac stuff | |||
*.DS_Store | |||
|
|||
# IDE files | |||
# QT Creator | |||
*.user |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're going to ignore *.user
, then a bunch of ignore rules below are not needed.
.gitignore
Outdated
@@ -7,8 +7,30 @@ default/ | |||
# Mac stuff | |||
*.DS_Store | |||
|
|||
# IDE files | |||
# QT Creator |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# QT Creator | |
# Qt Creator |
Oh, and the commits from #4073 came back. Please rebase instead of merging upstream. :-) |
Hmm, you do need to resolve the conflicts before doing |
I edit git ignore for other IDEs. This is the first step to add support for cmake build and make the project available to more developers.