Fix iOS installs: Support retrieval of NSNumber data types from CAPPluginCall options #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lincolnthree
changed the title
|
Thank you for fix the bugs!! LGTM 👍 👍 |
|
@leo6104 You're welcome! Thanks for doing most of the work to get things going! I need this plugin as much as you do :) Always happy to fix bugs if I can figure out what is going on. PS. Any word on Microsoft picking this up as a supported project? Have you had any communication with them? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes installs never being applied on iOS.
See also, PR on Capacitor to support this via their utilities since this is not currently handled:
ionic-team/capacitor#4303