[FEATURE] Returns layer Id on Feature Tap #475
+69
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zverik
suggested changes
Oct 3, 2024
| @@ -56,9 +56,9 @@ class MapLibreMapController: NSObject, FlutterPlatformView, MLNMapViewDelegate, | |||
| target: self, | |||
| action: #selector(handleMapTap(sender:)) | |||
| ) | |||
| for recognizer in mapView.gestureRecognizers! where recognizer is UITapGestureRecognizer { | |||
| /*for recognizer in mapView.gestureRecognizers! where recognizer is UITapGestureRecognizer { | |||
There was a problem hiding this comment.
My bad, this was to enhanced the speed of the callback, with this commented the interaction callback switch from 1s to 0.1s. I was unable to remove all the slow gestureRecognizers
| @@ -8,7 +8,7 @@ typedef OnMapClickCallback = void Function( | |||
| Point<double> point, LatLng coordinates); | |||
|
|
|||
| typedef OnFeatureInteractionCallback = void Function( | |||
| dynamic id, Point<double> point, LatLng coordinates); | |||
| dynamic id, Point<double> point, LatLng coordinates, String layerId); | |||
There was a problem hiding this comment.
My issue with this is that it changes the callback function signature. Fine since the library is not stable yet. But maybe it's type to make a InteractionEvent class to package all the attributes inside?
There was a problem hiding this comment.
Why not, but I don't think it's necessary, given that functionality is vital.
This reverts commit fdc7fa5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello MapLibre Team !
I needed to retrieve the layer Id of the feature tapped, so I've implemented it.
This is much cleaner than using the given Id to have a unique identifier and the layer id.
Best regards,
Louis