-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds missing test to CJK issue #1018
Conversation
Bundle size report: Size Change: 0 B
ℹ️ View DetailsNo major changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
I know :-) but at least you can use the received text, save it to a html file and see how it looks in the browser. |
How come the CI passes when this test fails? Is it because it only fails when we run it locally? |
I think so, yes. If I remember correctly, @HarelM chose to use base64 image encoding such that one can easily copy-paste the CI actual result to the expected result in version control... |
There are probably better ways to do it, but I wanted to have a CJK test in the CI as it's not possible to do it in the render tests. |
Adds missing test to #1002
It's not ideal as the image is saved in base64 format and is compared exactly, but I didn't want to complicate the test to use PNG and pixelmatch libraries...