Version with test #1471
Merged
Version with test #1471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bundle size report: Size Change: +15 B
ℹ️ View DetailsNo major changes |
This was referenced Aug 13, 2022
|
Interesting, seems that our hard work related to incorporating typescript in rollup paid off :-) |
HarelM
approved these changes
Aug 13, 2022
|
I agree, it's a really fortunate timing for this type of issue wrt typescript json imports that just landed days ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of #1459 towards resolving issues like this ( #1426)
Provides a way to get the package version, and add unit tests to make sure it's proper semver.
Because of compiler issues at the time this functionality was removed when we moved to typescript in this PR, specifically in this commit.