Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to typescript #209

Merged
merged 149 commits into from
Sep 3, 2021
Merged
Show file tree
Hide file tree
Changes from 118 commits
Commits
Show all changes
149 commits
Select commit Hold shift + click to select a range
cf52cc9
Update README.md
HarelM Jul 14, 2021
b5035a3
Initial commit - only rename and flow to typescript conversion
HarelM Jul 16, 2021
5f29228
Iint upgrade
HarelM Jul 16, 2021
36712e2
More lint fixes
HarelM Jul 16, 2021
c309e60
Updated lint command, added build typescript command
HarelM Jul 17, 2021
10876d9
Add non typed modules according to ts fork.
HarelM Jul 17, 2021
3f9310a
Switch from yarn to npm
wipfli Jul 17, 2021
ecfef62
Fix hasOwnProperty lint errors
Jul 17, 2021
0959b04
Fix extension from .js to .ts
Jul 17, 2021
33bb386
Remove types file
Jul 17, 2021
fa2b6ea
Ignore lint errors
Jul 17, 2021
a24a7ca
Remove .ts extension in import
Jul 17, 2021
9d8d47d
Update CI from node v10 to v14
HarelM Jul 13, 2021
19dd308
Replace yarn with npm
Jul 17, 2021
d2e3002
Remove circleci
Jul 17, 2021
93c3993
Fixed some typings errors
HarelM Jul 17, 2021
1116842
Explicitly convert matrix-gl types
Jul 18, 2021
c26511e
Automatically fix lint errors
Jul 18, 2021
42ddfe2
Avoid Function as callback type
Jul 18, 2021
5acb66c
Add missing MapOptions
Jul 18, 2021
99e90b8
Add pitchWithRotate to MapOptions and pass explicit options to Handle…
Jul 18, 2021
ff234e6
Set type of MapOptions.style to StyleSpecification of string
Jul 18, 2021
dbbefae
Make Camera an abstract class
Jul 18, 2021
9f653ee
Use Float32Array instead of Float64Array and cast types
Jul 18, 2021
d52ab71
Make object dynamically extendable
Jul 18, 2021
9a62b51
Make more objects dynamically extenable
Jul 18, 2021
4963f15
Explicit cast of array to length 2
Jul 18, 2021
5ca6493
Do not provide type any in for..in loop
Jul 18, 2021
b1e81ab
Make more objects dynamically extenable
Jul 18, 2021
59bdc8b
Cast layout.get return value to Number
Jul 18, 2021
e7bafda
Cast number | void to number
Jul 18, 2021
bcebaca
Specify Rect type
Jul 18, 2021
3199286
Make thhird argument of getKey optional
Jul 18, 2021
9fe8cf6
Cast number | void to number
Jul 18, 2021
4e72829
Define return type of parse() in subclasses of Expression
Jul 18, 2021
95781ad
Cast return type of context.error() from void to null
Jul 18, 2021
efc4b1f
Cast style-spec types to Type
Jul 18, 2021
f0a3c36
Cast return type of context.error() from void to null
Jul 18, 2021
4af74a6
Cast style-spec types to Type
Jul 18, 2021
948a035
Cast dict to StylePropertySpecification
Jul 18, 2021
dbae218
Specify array type as any to fix string[] inference
Jul 18, 2021
f8052f9
Make third argument of coalesce() optional
Jul 18, 2021
fb14039
Explicit casts to Evaluate, Varargs, and Signature
Jul 18, 2021
1783d6a
Revert "Cast style-spec types to Type"
Jul 18, 2021
89bee09
Revert "Cast style-spec types to Type"
Jul 18, 2021
a4a60a6
Cast style-spec types at their source
Jul 18, 2021
08ddb2c
Typescript: Remove @mapbox/geojson-types and replace with @types/GeoJ…
chippieTV Jul 23, 2021
6e966bd
add type to import GLSL as strings (#222)
chippieTV Jul 23, 2021
0e57cf8
Typescript: Use library to handle Window type (#223)
chippieTV Jul 23, 2021
7bb152f
Fix issues related to possibly evaluated design
HarelM Jul 24, 2021
c2c5b91
Move IControl interface to a new class, Fix timeoutID type.
HarelM Jul 24, 2021
33b3f49
remove flow-typed folder (#225)
chippieTV Jul 25, 2021
9aff296
Typescript: Remove reference to @mapbox/point-geometry TBC (#226)
chippieTV Jul 25, 2021
d7c7af3
Fix lint
HarelM Jul 25, 2021
4c6d8e7
Typescript: fix lint and update .eslintrc with alternate TS rule (#227)
chippieTV Jul 25, 2021
ac94146
Typescript: a number of minor fixes from WIP branch (#228)
chippieTV Jul 25, 2021
eafe46c
Fix small typings issues
HarelM Jul 25, 2021
0306da0
More typescript fixes
HarelM Jul 25, 2021
139726f
More fixes to typings, lint fixes
HarelM Jul 25, 2021
58eecb5
Change base calls to be abstract
HarelM Jul 25, 2021
e633436
More type fixes
HarelM Jul 26, 2021
9fd964e
More types fixes
HarelM Jul 26, 2021
a4ede9a
More types fixes
HarelM Jul 26, 2021
c48e970
update use of mat4 (#219)
chippieTV Jul 26, 2021
8f18665
Added some "as any" to places in the code where the typing were not j…
HarelM Jul 26, 2021
3e5768e
More types fixing, not perfect but good enough.
HarelM Jul 27, 2021
e2ee96f
Fix last typescript errors
HarelM Jul 27, 2021
a34f64b
Fix incorrect typings and code errors.
HarelM Jul 27, 2021
bd32057
Remove flow from rollup and add tsc to build
HarelM Jul 27, 2021
78a62c9
Format file
HarelM Jul 27, 2021
2710e4b
Fix rollup build
HarelM Jul 27, 2021
a963b6e
Initial commit to make the render test run
HarelM Jul 30, 2021
eb1ace7
Remove unneeded window import from all files
HarelM Jul 30, 2021
056a396
Remove version from API
HarelM Jul 30, 2021
a875ae6
More mock fixes to be able to run tests
HarelM Jul 30, 2021
63e17ce
fix running of test-expression (#232)
chippieTV Jul 31, 2021
a68ea80
Add build phase before running some of the tests
HarelM Jul 31, 2021
8e44d82
Fix tests get stuck, still tests are failing...
HarelM Jul 31, 2021
e0c7f89
get node query tests running (#233)
chippieTV Jul 31, 2021
70938ed
Fix mocking of case of tilejson implementation.
HarelM Jul 31, 2021
3a1c788
Typescript: Fix unit-tests (#235)
HarelM Aug 3, 2021
7978d04
Incorrect invocation of build-dev...
HarelM Aug 3, 2021
e2bced5
Fix lint errors
HarelM Aug 3, 2021
6046b61
Removed test flow
HarelM Aug 3, 2021
8f11ef3
Fix build csp, started to fix style build
HarelM Aug 4, 2021
0aae94b
Fix css build
HarelM Aug 4, 2021
c15469f
Remove to vec3 as to code review requirements
HarelM Aug 4, 2021
598d3d6
Remove flow from build in ci
HarelM Aug 4, 2021
24f374e
Remove references to @mapbox/point-geometry
HarelM Aug 4, 2021
baabb53
Allow building style-spec
HarelM Aug 4, 2021
79e4754
Fix build tests
HarelM Aug 4, 2021
f8208b3
Remove window, fix missing references to FeatureIndex using typescrip…
HarelM Aug 6, 2021
24e2c8f
Fix lint
HarelM Aug 6, 2021
3cee03e
Fix production build
HarelM Aug 6, 2021
e3eefb2
Remove buble, stop compiling for es5
HarelM Aug 6, 2021
f05202f
Added missing global definitions after removing window
HarelM Aug 6, 2021
784e23d
Fix tests, bring back web_worker mock file, fix maplibre-gl loading i…
HarelM Aug 7, 2021
6610b95
Fix build?
HarelM Aug 8, 2021
4db2629
Fix lint
HarelM Aug 8, 2021
1d76444
Typescript: Fix query-tests (#240)
HarelM Aug 8, 2021
140ad58
Fix some lint issues
HarelM Aug 8, 2021
c730494
Typescript: minor fixes to formatting (#241)
chippieTV Aug 9, 2021
4bccaaf
Remove unneeded comments
HarelM Aug 9, 2021
49411c6
Fix according to code review
HarelM Aug 9, 2021
532640a
Remove undefined as any
HarelM Aug 9, 2021
58ee617
Fix according to code review requirements.
HarelM Aug 9, 2021
6d0feff
Fix lint
HarelM Aug 9, 2021
debca9f
More lint cover and fixes
HarelM Aug 9, 2021
f7a2905
Fix lint for windows, update versions.
HarelM Aug 9, 2021
1d8e3f7
Fix browser tests due to incorrect lint fix
HarelM Aug 9, 2021
c86a14f
Fix lint for land.html
HarelM Aug 9, 2021
2c55e69
Fix minimal node version to 14
HarelM Aug 12, 2021
3b489d2
Typescript: merge from main (#243)
astridx Aug 14, 2021
0db9613
Merge branch 'main' into typescript
astridx Aug 15, 2021
27ce223
Update Life of a tile docs (#247)
astridx Aug 17, 2021
fdfb04d
Merge branch 'main' into typescript
astridx Aug 17, 2021
44c11ed
Update package.json (#248)
astridx Aug 18, 2021
708b7a0
Merge branch 'main' into typescript
astridx Aug 20, 2021
7d4192b
some updates from review (#252)
chippieTV Aug 25, 2021
f7ba71a
Fix WritingMode cast (#254)
wipfli Aug 25, 2021
41dae49
Run CI on all pull requests (#255)
wipfli Aug 28, 2021
83a69c3
Remove redundant parentheses (#257)
wipfli Aug 28, 2021
c5840a8
Remove (minify = false)
HarelM Aug 28, 2021
9db4f31
Merge branch 'typescript' of https://github.com/maplibre/maplibre-gl-…
HarelM Aug 28, 2021
6daaf50
Review cleanup (#259)
wipfli Aug 28, 2021
42ba236
Remove TODO, Fix according to code review changes
HarelM Aug 28, 2021
c6eed6c
Merge branch 'typescript' of https://github.com/maplibre/maplibre-gl-…
HarelM Aug 28, 2021
eebf172
Remove last TODOs.
HarelM Aug 28, 2021
78e1075
Updated changelog
HarelM Aug 28, 2021
0e569bc
Change publish style spec to reflect latest changes in typescript
HarelM Aug 28, 2021
f8dcc8d
Fix code review comments
HarelM Aug 28, 2021
db2bed5
Declare `emplace()` with variable number of arguments (#262)
wipfli Aug 28, 2021
75e6173
Fix comment of generated files
HarelM Aug 28, 2021
57c3545
Merge branch 'typescript' of https://github.com/maplibre/maplibre-gl-…
HarelM Aug 28, 2021
5f75b61
Fix according to code review
HarelM Aug 29, 2021
6a8559e
remove comment and update type in jsdoc (#269)
chippieTV Aug 29, 2021
c680068
Copy dist folder with `cp -r` (#274)
wipfli Aug 29, 2021
fd29d6c
Fix typo
wipfli Aug 29, 2021
343353e
Fix last comments about generated files.
HarelM Aug 29, 2021
84f118d
Merge branch 'typescript' of https://github.com/maplibre/maplibre-gl-…
HarelM Aug 29, 2021
7d9af25
Fix typos in comments (#283)
fredj Aug 31, 2021
7b126e1
Remove polyfill support for IE11 (#284)
fredj Aug 31, 2021
fa05f55
Enforce semicolons as member delimters (#282)
drwestco Aug 31, 2021
b6ac656
eslint - enforce single quotes (#285)
drwestco Aug 31, 2021
e0f7062
move point.ts from symbol/ to util/ (#287)
chippieTV Sep 1, 2021
148e23a
Remove undefined as any casts (#292)
drwestco Sep 1, 2021
87e555c
Remove feature detection for {passive: false} support (#291)
fredj Sep 1, 2021
de752a0
Changed version in package.json before merge
HarelM Sep 3, 2021
8d789b7
Remove the usage of devicePixelRatio as a getter from browser.ts (#294)
fredj Sep 3, 2021
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
231 changes: 0 additions & 231 deletions .circleci/config.yml

This file was deleted.

36 changes: 22 additions & 14 deletions .eslintrc
Original file line number Diff line number Diff line change
@@ -1,19 +1,33 @@
{
"extends": [
"mourner",
"plugin:flowtype/recommended",
"plugin:import/recommended"
// "plugin:@typescript-eslint/recommended",
wipfli marked this conversation as resolved.
Show resolved Hide resolved
"plugin:import/recommended",
"plugin:import/typescript"
],
"parser": "babel-eslint",
"parser": "@typescript-eslint/parser",
"parserOptions": {
"sourceType": "module"
"sourceType": "module",
"createDefaultProgram": true
},
"plugins": [
"flowtype",
"@typescript-eslint",
"import",
"jsdoc"
],
"rules": {
"@typescript-eslint/explicit-function-return-type": "off",
"@typescript-eslint/restrict-plus-operands": "off",
"@typescript-eslint/restrict-template-expressions": "off",
"@typescript-eslint/explicit-module-boundary-types": "off",
wipfli marked this conversation as resolved.
Show resolved Hide resolved
"no-dupe-class-members": "off",
"@typescript-eslint/no-dupe-class-members": ["error"],
"@typescript-eslint/no-unused-vars": [
"warn",
{ "argsIgnorePattern": "^_" }
],
// Disable no-undef. It's covered by @typescript-eslint
"no-undef": "off",
// temporarily disabled due to https://github.com/babel/babel-eslint/issues/485
"no-use-before-define": "off",

Expand All @@ -33,13 +47,6 @@

"array-bracket-spacing": "off",
"consistent-return": "off",
"flowtype/define-flow-type": 1,
"flowtype/require-valid-file-annotation": [
2,
"always", {
"annotationStyle": "line"
}
],
"global-require": "off",
"import/no-commonjs": "error",
"key-spacing": "off",
Expand All @@ -50,7 +57,7 @@
"object": "Object",
"property": "assign"
}],
"no-unused-vars": ["error", {"argsIgnorePattern": "^_$"}],
"no-unused-vars": "off",
"no-warning-comments": "error",
"object-curly-spacing": ["error", "never"],
"prefer-arrow-callback": "error",
Expand All @@ -72,7 +79,7 @@
"parameters": "off"
}
}],
"no-multiple-empty-lines": [ "error", {
"no-multiple-empty-lines": [ "error", {
"max": 1
}],
"jsdoc/check-param-names": "warn",
Expand All @@ -87,6 +94,7 @@
"ignorePrivate": true
}
},
"ignorePatterns": ["build/*.js", "*.json"],
"overrides": [
{
"files": ["debug/**", "bench/**", "test/**", "src/style-spec/**"],
Expand Down
61 changes: 0 additions & 61 deletions .flowconfig

This file was deleted.

6 changes: 3 additions & 3 deletions .github/workflows/analyze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,12 @@ jobs:
# report status back to pull request
- uses: haya14busa/action-workflow_run-status@v1
- uses: actions/checkout@v2
- name: Use Node.js 10 x64
- name: Use Node.js 14 x64
uses: actions/setup-node@v2-beta
with:
node-version: 10
node-version: 14
architecture: x64
- run: yarn install --frozen-lockfile
- run: npm ci
- name: Download branch artifact
uses: dawidd6/action-download-artifact@v2
with:
Expand Down
Loading