Change focusAfteropen default value to false

[naogify]

Close #338

Problem

When I set a popup on a marker and click on it, the focus is on the close button (x) and part of the text in the popup is hidden. This happens only when you click on the marker for the first time.

demo.mov

Solution

When I set false to options.focusAfterOpen, it did not happen.

Demo [FocusAfterOpen = false]

https://codepen.io/naogify/pen/dyRZrKo

Test

I run npm run test and this PR passed the tests. But I can't run npm run test-suite because of the error below. I'm glad if someone run the npm run test-suite to test this PR. (I will fix the error later. )

file:///Users/naoppy/naogify/maplibre-gl-js/test/suite_implementation.js:160
                now += operation[1];
                ^

ReferenceError: now is not defined
    at applyOperations (file:///Users/naoppy/naogify/maplibre-gl-js/test/suite_implementation.js:160:17)
    at applyOperations (file:///Users/naoppy/naogify/maplibre-gl-js/test/suite_implementation.js:211:13)
    at Map.<anonymous> (file:///Users/naoppy/naogify/maplibre-gl-js/test/suite_implementation.js:110:9)
    at Map.fire (file:///Users/naoppy/naogify/maplibre-gl-js/rollup/build/tsc/util/evented.js:92:26)
    at Map._render (file:///Users/naoppy/naogify/maplibre-gl-js/rollup/build/tsc/ui/map.js:2002:18)
    at Immediate.<anonymous> (file:///Users/naoppy/naogify/maplibre-gl-js/rollup/build/tsc/ui/map.js:2124:22)
    at processImmediate (internal/timers.js:466:21)

Launch Checklist

• confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
• briefly describe the changes in this PR
• include before/after visuals or gifs if this PR includes visual changes
• write tests for all new functionality
• document any changes to public APIs
• post benchmark scores
• manually test the debug page
• apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
• add an entry inside this element for inclusion in the maplibre-gl-js changelog: <changelog></changelog>

[github-actions]

Bundle size report:

Size Change: 0 B
Total Size Before: 194 kB
Total Size After: 194 kB

Output file	Before	After	Change
maplibre-gl.js	185 kB	185 kB	0 B
maplibre-gl.css	9.49 kB	9.49 kB	0 B

ℹ️ View Details

Source file	Before	After	Change
rollup/build/tsc/ui/popup.js	1.9 kB	1.9 kB	+3 B

[HarelM]

Can you please a changelog item? Are we sure this is OK with accessibility requirements?

[wipfli]

Are there any edge cases where the default should better be true?

[HarelM]

Accessibility is the only reason I can think of...

[wipfli]

...which is quite an important one. Actually if we can solve the issue with padding I would prefer it.

[HarelM]

@naogify sorry for the confusion, I tend to think now that padding might be the preferred option as opposed to what I wrote earlier. Sorry...

[naogify]

@HarelM

Sorry for the late reply. I actually agree with you, I think it's better to add padding-top.

I did some research on accessibility after that, and I think it's important for keyboard users to have the focus on the close button by default. So, I will close this PR! and crate PR of adding padding-top.