Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace v8 with monocart for coverage #3598

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Replace v8 with monocart for coverage #3598

merged 2 commits into from
Jan 23, 2024

Conversation

HarelM
Copy link
Collaborator

@HarelM HarelM commented Jan 21, 2024

Launch Checklist

In order to solve the coverage issues introduced with v8 and the render test a different coverage tool is needed apparently.
See here:
cenfun/monocart-coverage-reports#4
And here:
istanbuljs/v8-to-istanbul#238

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.

@HarelM HarelM changed the title Replace v8 with monocart Replace v8 with monocart for coverage Jan 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7decb26) 85.92% compared to head (b380686) 83.31%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3598      +/-   ##
==========================================
- Coverage   85.92%   83.31%   -2.61%     
==========================================
  Files         244      244              
  Lines       48269    32200   -16069     
  Branches     5152     4398     -754     
==========================================
- Hits        41473    26828   -14645     
+ Misses       6796     5124    -1672     
- Partials        0      248     +248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 22, 2024

Thanks @neodescis! I'm still looking for a complete solution. While this fix is in the right direction, it still doesn't fix the entire problem as there are reported "missing" end brakets.
I have an idea how to solve this, but it might not work and I'll simply merge this fix.

@HarelM
Copy link
Collaborator Author

HarelM commented Jan 23, 2024

It's better than what we currently have, I'll merge this and see how to continue improving this in the future.

@HarelM HarelM merged commit 390a0bc into main Jan 23, 2024
15 checks passed
@HarelM HarelM deleted the fix-coverage branch January 23, 2024 20:12
@HarelM HarelM mentioned this pull request Jun 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants