-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minify SVG icons #4181
Minify SVG icons #4181
Conversation
Reduces file size = faster loading Uses: https://svgo.dev/ via command line `npx svgo --folder=\"src/css/svg/\"`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4181 +/- ##
==========================================
+ Coverage 87.62% 87.66% +0.03%
==========================================
Files 242 242
Lines 33076 33076
Branches 2177 2159 -18
==========================================
+ Hits 28984 28997 +13
+ Misses 3109 3108 -1
+ Partials 983 971 -12 ☔ View full report in Codecov by Sentry. |
These svgs are copied into the css. So I think it will be better to go that route, what do you think? |
This reverts commit 6b45b24.
ah ok, I'm fine if you want to close this then but I think there are a few micro-optimisations with the changes in this PR though. I set the script to pretty-print them so they are more human-readable... let me know what you think. |
This reverts commit 75a77c0.
Reduces file size = faster loading Uses: https://svgo.dev/ via command line `npx svgo --folder=\"src/css/svg/\"` Revert "Minify SVG icons" This reverts commit 6b45b24. SVGO pretty printed Revert "SVGO pretty printed" This reverts commit 75a77c0. don't remove viewBox property
…plibre-gl-js into dev/coliff/minify-svgs
The only change is the addition of the viewbox, is this a must? |
I must have looked at something different, not sure how. |
I introduced a bug with maplibre#4181 by removing the ids for parts oft he compass which are actually used in the CSS to hide/change depending on the state. This PR adds those ids back.
I introduced a bug with #4181 by removing the ids for parts oft he compass which are actually used in the CSS to hide/change depending on the state. This PR adds those ids back. Co-authored-by: Harel M <[email protected]>
Reduces file size = faster loading
Uses: https://svgo.dev/ via command line
npx svgo --folder=\"src/css/svg/\"
Launch Checklist
CHANGELOG.md
under the## main
section.Command line output: