Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol layer flickering after zooming out #16

Closed
moodstubos opened this issue Feb 11, 2021 · 6 comments · Fixed by #34
Closed

Symbol layer flickering after zooming out #16

moodstubos opened this issue Feb 11, 2021 · 6 comments · Fixed by #34
Labels
help wanted Extra attention is needed

Comments

@moodstubos
Copy link

Mapbox 6.0 got an update for this (unfortunately after license change):

🐞 Bug fixes
Fixed an issue where symbols flickered when zooming out. (mapbox/mapbox-gl-native#16471, mapbox/mapbox-gl-native-ios/issues/273)

source 1: https://github.com/mapbox/mapbox-gl-native-ios/blob/master/platform/ios/CHANGELOG.md
source 2: mapbox/mapbox-gl-native#16473 (comment)

Found this issue in maplibre-gl-native android as well as ios.

Unfortunately I could not find any original commit in mapbox-gl-native repo for the mentioned fixes. I pretty sure its in the closed code therefore.

Perhaps someone has an idea where to begin for fixing this.
By the way: older versions of mapbox-gl-native-android (e.g. 8.6.7) does not have this issue (not yet tested for older ios versions).

@petr-pokorny-1 petr-pokorny-1 added the help wanted Extra attention is needed label Feb 19, 2021
@ystsoi
Copy link
Contributor

ystsoi commented Feb 28, 2021

Hi, I am the reporter of the issue mapbox/mapbox-gl-native#16471. Actually, I have a custom patch for some flickering issues, and I have uploaded it to ystsoi@52c2ce7. The patch is for Mapbox, and I have not tested it against MapLibre. However, I think that it should work on MapLibre too, please try it.

petr-pokorny-1 added a commit that referenced this issue Feb 28, 2021
@petr-pokorny-1
Copy link
Contributor

petr-pokorny-1 commented Feb 28, 2021

Thanks for help @ystsoi ! The patch seems to work well.

I have tested it on Android. Here is video before fix
And here after applying the patch

@moodstubos
Copy link
Author

@ystsoi
thank you so much for sharing your patch!!
I just tried and it completly prevents flickering.

@petr-pokorny-1 petr-pokorny-1 added this to the android 9.3.0 milestone Feb 28, 2021
@gokugen
Copy link

gokugen commented May 14, 2021

Hi, thank you for the patch! It works pretty well on Android.
However i'm still facing this issue on IOS... Did you find a solution for this ?

@gokugen
Copy link

gokugen commented May 14, 2021

Update: After upgrading Mapbox IOS SDK to the last version using https://github.com/react-native-mapbox-gl/maps/blob/master/ios/install.md#mapbox-maps-sdk the problem disappear!

@ferdicus
Copy link

@gokugen, the provided link you've posted has nothing to do with MapLibre though - I'm posting this to make you aware of that.

THIS repo is MapLibre, when you follow the steps in (https://github.com/react-native-mapbox-gl/maps/blob/master/ios/install.md#mapbox-maps-sdk ) you will update the SDK version of the Mapbox iOS SDK, not of the MapLibre SDK.

nvanfleet pushed a commit to lyft/maplibre-gl-native that referenced this issue Jul 28, 2022
This PR is updating the version of this image's parent (`bionicbase`) to keep this image (`maplibreglnativeprivate`) up-to-date.
It will be merged if all tests pass via `/merge-skip-owners`; if tests do not pass, it will require manual intervention.

For more details please see the [docs about Automatic Updates](https://docs.lyft.net/eng/provisioningdocs/learning/automatic_updates.html).

[Here is what's changed in `bionicbase`](lyft/containers@8cfc73e...20c7e22).

REVIEWS WERE BYPASSED
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants