Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Avoid throwing null pointer exception on slow initialization #22

Closed
petr-pokorny-1 opened this issue Feb 20, 2021 · 0 comments · Fixed by #35
Closed

[Android] Avoid throwing null pointer exception on slow initialization #22

petr-pokorny-1 opened this issue Feb 20, 2021 · 0 comments · Fixed by #35
Assignees
@petr-pokorny-1
Milestone
android-v9.4.0

Comments

@petr-pokorny-1
Copy link
Contributor

Cherry pick from https://github.com/mapbox/mapbox-gl-native-android/pull/466/files
@petr-pokorny-1 petr-pokorny-1 added this to the android 9.3.0 milestone Feb 20, 2021
@petr-pokorny-1 petr-pokorny-1 self-assigned this Feb 20, 2021
petr-pokorny-1 added a commit that referenced this issue Mar 3, 2021
@petr-pokorny-1
Cherry pick from https://github.com/mapbox/mapbox-gl-native-android/p…
a36cc15 
…ull/466/files

resolves #22
@petr-pokorny-1 petr-pokorny-1 mentioned this issue Mar 3, 2021
Merged
nvanfleet pushed a commit to lyft/maplibre-gl-native that referenced this issue Jul 28, 2022
@rmyhal
Fix incorrect calculation of vertical shift (maplibre#22)
fca853f 
In [this PR](https://github.com/maplibre/maplibre-gl-native/pull/270/files#diff-d57cd3143ace69af2f7ae79a917ac1328acc7543ae8a2a15f58b4635b86f1b91R148) in the maplibre there was a typo during adding `static_cast<float>`.  And because of this the logic of calculation `shiftY` is broken. This PR makes it correct.



| Before | After |
| - | - |
| <img width="390" alt="image" src="https://user-images.githubusercontent.com/8909650/168667685-587d1ca4-54a2-435c-99ed-0be575304b68.png"> |  <img width="388" alt="image" src="https://user-images.githubusercontent.com/8909650/168667701-85940ff2-66a5-4e47-828e-573279ea5620.png"> |
@sjg-wdw sjg-wdw mentioned this issue Apr 30, 2024
Open
@louwers louwers mentioned this issue May 27, 2024
Closed
@nijs9 nijs9 mentioned this issue Oct 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petr-pokorny-1 petr-pokorny-1

Labels
None yet
Projects
None yet
Milestone
android-v9.4.0
Development

Successfully merging a pull request may close this issue.

Avoid throwing null pointer exception on slow initialization maplibre/maplibre-native
1 participant
@petr-pokorny-1