-
-
Notifications
You must be signed in to change notification settings - Fork 300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design proposal: ambient cache initialization speed improvement #1877
Design proposal: ambient cache initialization speed improvement #1877
Conversation
@JesseCrocker Was your comment answered to your satisfaction by this answer? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK to me, made some textual suggestions.
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
design-proposals/2023-11-06-ambient-cache-initialization-speed-improvement.md
Outdated
Show resolved
Hide resolved
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…-improvement.md Co-authored-by: Bart Louwers <[email protected]>
…ibre#1877) Co-authored-by: Christophe Brasseur <[email protected]> Co-authored-by: Bart Louwers <[email protected]> Co-authored-by: Bart Louwers <[email protected]>
Hello. I have an additional question about the implementation of the changes in the deletion of offline regions: With our changes, when an offline region is deleted, tiles and resources which are not used anymore in any other offline region are not moved to the ambient cache again (which would impact the performance because we would have to move the data from tiles / resources tables to ambient_tiles / ambient_resources) but simply removed from the tiles / resources tables in the database. However, it causes a behaviour change : these resources and tiles are deleted from the database, they don't return to the ambient cache, where the deletion should take the LRU mechanism into account. Is this behaviour change acceptable? If it is not acceptable, what would you suggest to avoid impacting the performance? Thanks in advance. |
When deleting a locally stored region for offline usage, I think it is expected that that region needs to be re-downloaded. I wonder if @JesseCrocker agrees? |
Added design proposal for ambient cache initialization speed improvement to fix issue #1815
I recreated a pull request to isolate the design proposal for the implementation. Sorry for the inconvenience.
Original pull request here : #1839