Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design proposal: ambient cache initialization speed improvement #1877

Merged
merged 12 commits into from
Nov 20, 2023

Conversation

geolives-contact
Copy link
Contributor

Added design proposal for ambient cache initialization speed improvement to fix issue #1815

I recreated a pull request to isolate the design proposal for the implementation. Sorry for the inconvenience.
Original pull request here : #1839

@geolives-contact geolives-contact changed the title Proposals/ambient cache slowness Design proposal: ambient cache initialization speed improvement Nov 20, 2023
@louwers
Copy link
Collaborator

louwers commented Nov 20, 2023

@JesseCrocker Was your comment answered to your satisfaction by this answer?

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me, made some textual suggestions.

@louwers louwers enabled auto-merge (squash) November 20, 2023 20:57
@louwers louwers merged commit 98860f4 into maplibre:main Nov 20, 2023
15 checks passed
louwers added a commit to louwers/maplibre-native that referenced this pull request Nov 30, 2023
…ibre#1877)

Co-authored-by: Christophe Brasseur <[email protected]>
Co-authored-by: Bart Louwers <[email protected]>
Co-authored-by: Bart Louwers <[email protected]>
@geolives-contact
Copy link
Contributor Author

Hello.

I have an additional question about the implementation of the changes in the deletion of offline regions:

With our changes, when an offline region is deleted, tiles and resources which are not used anymore in any other offline region are not moved to the ambient cache again (which would impact the performance because we would have to move the data from tiles / resources tables to ambient_tiles / ambient_resources) but simply removed from the tiles / resources tables in the database.

However, it causes a behaviour change : these resources and tiles are deleted from the database, they don't return to the ambient cache, where the deletion should take the LRU mechanism into account.

Is this behaviour change acceptable?

If it is not acceptable, what would you suggest to avoid impacting the performance?

Thanks in advance.

@louwers
Copy link
Collaborator

louwers commented Dec 14, 2023

When deleting a locally stored region for offline usage, I think it is expected that that region needs to be re-downloaded. I wonder if @JesseCrocker agrees?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants