Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[opengl-2][node] Release node-v5.4.1-pre.0 #2553

Merged
merged 7 commits into from
Jun 26, 2024

Conversation

acalcutt
Copy link
Collaborator

Releases node-v5.4.1-pre.0.

This also adds publishing the node 22 binary so that can be tested in this pre-release. I did not remove Node 16 at the same time, so this isn't a breaking change.

Note, I want to merge this after #2552

@acalcutt acalcutt changed the title [open-gl2][node] Release node-v5.4.1-pre.0 [opengl-2][node] Release node-v5.4.1-pre.0 Jun 26, 2024
@ntadej
Copy link
Collaborator

ntadej commented Jun 26, 2024

Looks OK to me.

@acalcutt acalcutt marked this pull request as ready for review June 26, 2024 12:40
@acalcutt
Copy link
Collaborator Author

@ntadej do you have any ideas for the failed qt test. I don't think it has to do with this PR

@ntadej
Copy link
Collaborator

ntadej commented Jun 26, 2024

Probably just a glitch, let's see now.

@acalcutt
Copy link
Collaborator Author

nice, looks like it passed on the re-run

@ntadej ntadej merged commit 87a604d into maplibre:opengl-2 Jun 26, 2024
13 checks passed
@acalcutt
Copy link
Collaborator Author

acalcutt commented Jun 27, 2024

This seems to work, but I had some trouble in windows at first. I ended up having to update my c++ redistributable. Without the update, when i tried to use it in tileserver-gl, the application just ended with no error.

I had the c++ 2015-2022 redistributable, but there was a slightly newer version of it that must have been needed with the vpkg update. I should probably add a note for that

I haven't gotten to test node 22 yet, but mainly because I am having trouble getting 'canvas' to work with node 22 , so my usually throw it into tileserver test isn't working yet.

acalcutt added a commit to WifiDB/maplibre-native that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants