Tile diff #2719
Draft
Tile diff #2719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… layers have only one drawable per tile
TimSylvester
force-pushed
the
tile-diff
branch
from
b9b29e1
to
5b1b35b
Compare
integrate with `render_layer` start on fill conversion
Bloaty Results (iOS) 🐋Compared to main Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2719-compared-to-main.txt |
# Conflicts: # src/mbgl/renderer/layers/render_circle_layer.cpp # src/mbgl/renderer/layers/render_fill_extrusion_layer.cpp # src/mbgl/renderer/layers/render_fill_layer.cpp # src/mbgl/renderer/layers/render_symbol_layer.cpp # src/mbgl/renderer/render_layer.cpp # src/mbgl/renderer/sources/render_tile_source.hpp
|
Benchmark Results ⚡ Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2719-compared-to-main.txt |
…ders when they're not needed
# Conflicts: # include/mbgl/renderer/renderer.hpp # src/mbgl/renderer/layers/render_fill_layer.cpp # src/mbgl/renderer/renderer.cpp
Prevent crash when adding a custom drawable layer twice.
|
Well, after all that, it doesn't really help at all, and in fact seems to be just a bit slower. In addition, I thought this was going to simplify things but, because layers can not be updated every frame, the complications involved in re-synchronizing offset the benefits. It does potentially allow the large layer update methods to be split up into three parts, but they remain dependent (updates can find that a remove/add is necessary). Finally, I think this would actually make it more difficult to transition the layer updates to a background thread. So I'm leaning towards dropping this one.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only calculate which tiles were added and removed once per frame instead of separately in each layer update.