Add PropertyFactory.iconPadding(Float) overload for better backcompat #2880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louwers
reviewed
Sep 28, 2024
| * @return property wrapper around Float | ||
| */ | ||
| public static PropertyValue<Float> <%- camelizeWithLeadingLowercase(property.name) %>(Float value) { | ||
| return new LayoutPropertyValue<>("<%- property.name %>", value); |
There was a problem hiding this comment.
Shouldn't this be wrapped in new Float[]{value}?
There was a problem hiding this comment.
Converter supports both numbers and arrays, so it will work both ways. With number there is a miniscule gain because we don't need to get Convertible into std::vector :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2873 for details.