Fix compass warning in the MGLMapView #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting this error but I had set the compass visibility to hidden (But not the UIView setting of isHidden). I think the logic for this error should check one, or both, of the isHidden values.
|
@nvanfleet , if you rebase this branch to main, the CI should run properly. |
@birkskyum done |
ntadej
approved these changes
Oct 1, 2022
|
Looks good for me. I wonder if we should add a changelog entry for iOS. |
@ntadej done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting this error but I had set the compass visibility to hidden (But not the UIView setting of isHidden).
I think the logic for this error should check one, or both, of the isHidden values.