Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention both spritezero and spreet #785

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Mention both spritezero and spreet #785

merged 2 commits into from
Aug 29, 2024

Conversation

pka
Copy link
Contributor

@pka pka commented Aug 21, 2024

The referenced spritezero application is archived. spreet is actively maintained.

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.70%. Comparing base (6a5aabf) to head (36b9dcf).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   92.70%   92.70%           
=======================================
  Files         105      105           
  Lines        4646     4646           
  Branches     1312     1312           
=======================================
  Hits         4307     4307           
  Misses        339      339           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HarelM
Copy link
Collaborator

HarelM commented Aug 22, 2024

Is there something more popular?
I'll see how they respond to the following request.
flother/spreet#83

@pka
Copy link
Contributor Author

pka commented Aug 22, 2024

I guess, spritezero ist still far more popular and I don't know of any other. We could also point to both tools?

@pka
Copy link
Contributor Author

pka commented Aug 22, 2024

OSM Americana seems to use @basemaps/sprites, despite the workflow graphics which contains spritezero.

@HarelM
Copy link
Collaborator

HarelM commented Aug 24, 2024

I think pointing to both tools at the moment might be a safer approach.

docs/sprite.md Outdated Show resolved Hide resolved
@louwers louwers requested a review from HarelM August 29, 2024 12:05
@louwers louwers changed the title Replace deprecated spritezero with spreet Mention both spritezero and spreet Aug 29, 2024
@HarelM HarelM merged commit fad3de8 into maplibre:main Aug 29, 2024
6 checks passed
@pka pka deleted the spreet branch August 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants