change docker to use port 8080 by default #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the docker images to use the default 8080 port and updates all the documentation. Opening on port 80 usually requires root access, so moving it to port 8080 makes it easier to start as a non-root user. I think it also makes it visually easier to understand, since the prompt "Listening at http://[::]:8080/" will actually match the port the user needs to go to to access the server.
There are several issues and PRs that would be helped by moving the default port to 8080, ex
#573
#578
#503
My only concern with this is it is somewhat of a breaking change for users expecting the docker to start on port 80, but I think this will be better off on a higher port.