This repository has been archived by the owner on Jun 25, 2024. It is now read-only.
Removes body data from http 204 response #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Make sense. Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The HTTP 1.1 specification states the following on the 204 No content status code definition:
Some Vector Tile libraries (at least Mapbox GL Native and Mapbox GL React Native) throw an error if a body message is present on an HTTP response with the 204 status code. This PR removes the body message from the response when an HTTP 204 response is sent.
Note: This PR is the same as the one in tileserver-gl/pull/339 but with the changes done in tileserver.php