Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto point to new release #9

Merged
merged 83 commits into from
Dec 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
83 commits
Select commit Hold shift + click to select a range
93cb9f7
update bw2io requirement
marc-vdm Sep 17, 2023
887992a
Update readme install instructions
marc-vdm Sep 17, 2023
8fc98bc
Update meta.yaml
marc-vdm Sep 17, 2023
ca017d2
Update README.md
marc-vdm Sep 17, 2023
7e64f2b
Change requirement to brightway2 instead of bw2io
marc-vdm Sep 18, 2023
a5edea6
Minor documentation + code improvements
marc-vdm Sep 22, 2023
f4720a8
Minor documentation + code improvements
marc-vdm Sep 22, 2023
119a5ba
Merge remote-tracking branch 'origin/contribution_analysis' into cont…
marc-vdm Sep 22, 2023
9c625ef
Minor documentation + code improvements
marc-vdm Sep 22, 2023
b54d7de
Increases the flexibility of the excel importer so it can also handle…
Zoophobus Sep 22, 2023
d8fbe1e
Merge branch 'LCA-ActivityBrowser:master' into excel_import_bug
Zoophobus Sep 22, 2023
d000f12
Set up signals infrascructure
marc-vdm Sep 22, 2023
86922c1
Implement dialog
marc-vdm Sep 23, 2023
8d55c6c
Implement finding of suitable alternatives and proper management of f…
marc-vdm Sep 23, 2023
db41a5b
Update README.md
bsteubing Sep 25, 2023
ef46b87
Implement actual relinking
marc-vdm Sep 25, 2023
ce767d3
Merge branch 'master' of https://github.com/LCA-ActivityBrowser/activ…
marc-vdm Sep 25, 2023
d90f7ea
Merge pull request #1050 from Zoophobus/excel_import_bug
marc-vdm Sep 25, 2023
58c7ad7
Minor documentation improvements + store exchanges to remove instead …
marc-vdm Sep 26, 2023
b219a40
Update README.md
bsteubing Sep 27, 2023
f8f58a1
Resolve #782 + improve documentation of `Contributions` class
marc-vdm Sep 28, 2023
578ba1c
Merge remote-tracking branch 'origin/contribution_analysis' into cont…
marc-vdm Sep 28, 2023
1ec86fc
Fix type hinting error
marc-vdm Sep 28, 2023
39d5271
Merge pull request #1051 from marc-vdm/duplicate_to_new_location
marc-vdm Oct 11, 2023
1ba49e1
Merge pull request #1045 from marc-vdm/contribution_analysis
marc-vdm Oct 11, 2023
fac2e7c
Merge branch 'master' into update_bw2io_requirement
marc-vdm Oct 11, 2023
0cd0fb8
Update README.md
marc-vdm Oct 11, 2023
0b25a81
Update README.md
marc-vdm Oct 11, 2023
ce1582f
Merge pull request #1041 from marc-vdm/update_bw2io_requirement
marc-vdm Oct 11, 2023
400cc35
Update README.md
marc-vdm Oct 11, 2023
0916c44
Updates to the functions get_relevant_flows and get_relevant_activiti…
Zoophobus Oct 14, 2023
5a953a0
Multiple sdf update (#1083)
Zoophobus Oct 20, 2023
7b9a11b
Updated and improved contributing file
marc-vdm Oct 21, 2023
7593d3b
Improve text on dependencies
marc-vdm Oct 21, 2023
8092279
Fix canary link
marc-vdm Oct 21, 2023
8b6493c
Add good/bad examples to CONTRIBUTING.md for commit messages and PR t…
marc-vdm Oct 21, 2023
16643d6
Add more specific requirements on communicating work on issues in CON…
marc-vdm Oct 21, 2023
e1a5f15
Minor updates to CONTRIBUTING.md and README.md
marc-vdm Oct 23, 2023
af1dd6a
Minor improvements to CONTRIBUTING.md
marc-vdm Oct 24, 2023
a01f012
Use node16 actions for main pipeline
haasad Oct 29, 2023
dfdf3b6
Use node16 actions in release pipeline
haasad Oct 29, 2023
aa03a54
Use latest version of release-changelog-builder
haasad Oct 29, 2023
3ce417f
Use node16 action for install canary pipeline
haasad Oct 29, 2023
c7b7ed8
Merge pull request #1095 from LCA-ActivityBrowser/update-actions-node16
haasad Oct 29, 2023
84ff87c
Remove the special build for arm architecture
haasad Oct 29, 2023
7e2647d
Merge pull request #1096 from LCA-ActivityBrowser/remove-arm-special-…
haasad Oct 29, 2023
6dddfd7
Install canary updates (#1093)
haasad Oct 30, 2023
6199183
Adding error message if no scenario file is loaded in a scenario LCA …
bsteubing Nov 2, 2023
61bf99e
Merge pull request #1088 from marc-vdm/improved_contributing_file
marc-vdm Nov 2, 2023
c9d1a75
Resolve #1105
marc-vdm Nov 7, 2023
015d6e7
Fix formatting error in PULL_REQUEST_TEMPLATE.md
marc-vdm Nov 7, 2023
bd73ac5
Resolve 3 bugs for location linking (#1051): 1) database of own activ…
marc-vdm Nov 7, 2023
deb1a81
Improve choosing and handling of alternative locations for location c…
marc-vdm Nov 7, 2023
ffec104
Update copyright and license information to only link to one place.
marc-vdm Nov 7, 2023
231f26c
Resolve readonly database bug for activity duplication to new activity.
marc-vdm Nov 8, 2023
b30b7e5
Merge pull request #1106 from marc-vdm/db_exporter_1105
marc-vdm Nov 8, 2023
b771689
Merge pull request #1111 from marc-vdm/update_copyright_and_license_info
marc-vdm Nov 8, 2023
6cfbebd
Merge pull request #1110 from marc-vdm/location_linking_bugs
marc-vdm Nov 8, 2023
47dba7b
Store AB version in logfile
marc-vdm Nov 9, 2023
863cd75
Merge pull request #1114 from marc-vdm/log_version_on_startup
marc-vdm Nov 9, 2023
13b7648
Remove deprecated channels from conda envs
haasad Nov 10, 2023
90a0388
Remove experimental conda environment creation and upload
haasad Nov 10, 2023
7eebd42
Merge pull request #1118 from LCA-ActivityBrowser/tidy-up-conda-envs
haasad Nov 10, 2023
45eb426
Move conda-envs to .github directory
haasad Nov 10, 2023
d267691
Move changelog config to .github
haasad Nov 10, 2023
b074195
Move dev recipe to .github directory
haasad Nov 10, 2023
8caa892
Move stable recipe to recipe/meta.yaml
haasad Nov 10, 2023
e54e645
Update dev recipe
haasad Nov 10, 2023
de49deb
Use micromamba instead of miniconda to speed up tests
haasad Nov 10, 2023
5c7b5e6
Update install instructions to use libmamba solver with conda
haasad Nov 11, 2023
f419894
Merge pull request #1119 from LCA-ActivityBrowser/reorganize-workflow…
marc-vdm Nov 13, 2023
f9da392
Merge pull request #1120 from LCA-ActivityBrowser/micromamba-actions
marc-vdm Nov 13, 2023
70259e1
Merge pull request #1121 from LCA-ActivityBrowser/libmamba-solver-ins…
marc-vdm Nov 13, 2023
6f6e1c4
Fix path for dev recipe
haasad Nov 13, 2023
c722b17
Merge pull request #1123 from haasad/fix/dev-build
haasad Nov 13, 2023
9b52614
Added tooltip for table content
mrvisscher Nov 16, 2023
55f90a5
Added docstring for data method
mrvisscher Nov 16, 2023
07cd9ef
Cleaning-up documentation
mrvisscher Nov 17, 2023
d23a9d2
Merge pull request #1130 from mrvisscher/table-tooltip
marc-vdm Nov 17, 2023
b4b1f74
Update README.md
marc-vdm Nov 22, 2023
96cba13
Add - copy on impact category copy (#1136)
mrvisscher Nov 24, 2023
fe69950
Resolve bug with switching project on delete (#1138)
mrvisscher Nov 28, 2023
7999944
GH action script for commenting on issues when related milestone is c…
marc-vdm Dec 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@ Contributors guide: ./CONTRIBUTING.md

## Checklist
<!--
Remove items that do not apply. For completed items, change [ ] to [x].
Remove items that do not apply. For completed items, change [ ] to [x] or you can click the checkboxes once your
pull-request is published.
-->

- [ ] Keep pull requests small so they can be easily reviewed.
Expand All @@ -16,7 +17,8 @@ Remove items that do not apply. For completed items, change [ ] to [x].
- [ ] Categorize the PR by setting a good title and adding one of the labels:
`bug`, `feature`, `ui`, `change`, `documentation`, `breaking`, `ci`
as they show up in the changelog
- [ ] Link this PR to related issues.
- [ ] Link this PR to related issues by using [closing keywords](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue).
- [ ] Request a review from another developer.

<!--
NOTE: these things are not required to open a PR and can be done afterwards,
Expand Down
File renamed without changes.
2 changes: 0 additions & 2 deletions ci/conda-envs/build.yml → .github/conda-envs/build.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: build
channels:
- conda-forge
- cmutel
- bsteubing
dependencies:
- conda-build
- anaconda-client
Expand Down
2 changes: 0 additions & 2 deletions ci/conda-envs/test.yml → .github/conda-envs/test.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
name: test
channels:
- conda-forge
- cmutel
- bsteubing
dependencies:
- pytest
- pytest-qt
Expand Down
6 changes: 4 additions & 2 deletions ci/recipe/dev/meta.yaml → .github/dev-recipe/meta.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
# conda recipe for activity-browser-dev
# https://anaconda.org/bsteubing/activity-browser-dev
package:
name: "{{ os.environ.get('PKG_NAME', 'activity-browser-dev') }}"
version: "{{ os.environ.get('VERSION', 'dev') }}"

source:
path: ../../..
path: ../..

build:
noarch: python
Expand All @@ -20,7 +22,7 @@ requirements:
build:
- python
- setuptools
run: # dependencies are added via github action from ci/recipe/stable/meta.yaml
run: # dependencies are added via github action from stable at recipe/meta.yaml

about:
home: https://github.com/LCA-ActivityBrowser/activity-browser
Expand Down
33 changes: 33 additions & 0 deletions .github/workflows/comment-milestoned-issues.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Comment when milestone is closed
on:
issues:
types: [milestoned]

comment:
runs-on: ubuntu-latest
steps:
- name: Comment on issue
uses: actions/github-script@v5
with:
script: |
const issue_number = context.issue.number;
const milestone_title = context.payload.issue.milestone.title;

// Get all milestones
const milestones = await github.rest.issues.listMilestones({
owner: context.repo.owner,
repo: context.repo.repo,
});

// Find the closed milestone that matches the title
const closedMilestone = milestones.data.find(milestone => milestone.title === milestone_title && milestone.state === 'closed');

if (closedMilestone) {
// Post a comment on the issue
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: issue_number,
body: `This issue has been resolved in Activity Browser [version ${milestone_title](https://github.com/LCA-ActivityBrowser/activity-browser/releases/tag/${milestone_title), please [update Activity Browser](https://github.com/LCA-ActivityBrowser/activity-browser#updating-the-ab).`,
});
}
67 changes: 64 additions & 3 deletions .github/workflows/install-canary.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ on:

jobs:
canary-installs:
runs-on: ${{ matrix.os }}
timeout-minutes: 12
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
matrix:
Expand All @@ -26,15 +26,76 @@ jobs:
python-version: ${{ matrix.python-version }}
- name: Install activity-browser
run: |
conda create -y -n ab -c conda-forge activity-browser python=${{ matrix.python-version }}
conda create -y -n ab -c conda-forge --solver libmamba activity-browser python=${{ matrix.python-version }}
- name: Environment info
run: |
conda activate ab
conda list
conda env export
conda env export -f env.yaml
- name: Upload final environment as artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: env-${{ matrix.os }}-${{ matrix.python-version }}
path: env.yaml

# also run install with micromamba instead of conda to have a timining comparison
canary-installs-mamba:
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
python-version: ['3.9']
defaults:
run:
shell: bash -l {0}
steps:
- name: Setup python ${{ matrix.python-version }} conda environment
uses: mamba-org/setup-micromamba@v1
with:
environment-name: ab
create-args: >-
python=${{ matrix.python-version }}
activity-browser
- name: Environment info
run: |
micromamba list
micromamba env export
micromamba env export > env.yaml
- name: Upload final environment as artifact
uses: actions/upload-artifact@v3
with:
name: env-${{ matrix.os }}-${{ matrix.python-version }}-mamba
path: env.yaml

conda-micromamba-comparison:
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
needs:
- canary-installs
- canary-installs-mamba
steps:
- name: Download all artifacts
uses: actions/download-artifact@v3
- name: show files
run: |
ls -la
- name: correct yaml formatting
# add correct indentation to make diffing possible
uses: mikefarah/yq@master
with:
cmd: |
ls | grep mamba | while read d; do yq -i $d/env.yaml; done
- name: diff ubuntu
run: |
diff -u env-ubuntu-latest-3.9* || :
- name: diff windows
run: |
diff -u env-windows-latest-3.9* || :
- name: diff macos
run: |
diff -u env-macos-latest-3.9* || :
88 changes: 20 additions & 68 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,17 @@ jobs:
patch-test-environment:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Patch test environment dependencies
# This step adds the run requirements from the stable recipe to the test environment
uses: mikefarah/yq@master
with:
cmd: |
yq eval-all 'select(fi == 0).dependencies += select(fi == 1).requirements.run | select(fi == 0)' ci/conda-envs/test.yml ci/recipe/stable/meta.yaml > patched-environment.yml
yq eval-all 'select(fi == 0).dependencies += select(fi == 1).requirements.run | select(fi == 0)' .github/conda-envs/test.yml recipe/meta.yaml > patched-environment.yml
- name: Show patched environment
run: cat patched-environment.yml
- name: Upload patched environment as artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: patched-environment
path: patched-environment.yml
Expand All @@ -38,24 +38,25 @@ jobs:
run:
shell: bash -l {0}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Download patched test environment
uses: actions/download-artifact@v2
uses: actions/download-artifact@v3
with:
name: patched-environment
- name: Setup python ${{ matrix.python-version }} conda environment
uses: conda-incubator/setup-miniconda@v2
uses: mamba-org/setup-micromamba@v1
with:
python-version: ${{ matrix.python-version }}
activate-environment: test
environment-name: test
environment-file: patched-environment.yml
create-args: >-
python=${{ matrix.python-version }}
- name: Environment info
run: |
conda list
conda env export
conda env export -f env.yaml
micromamba list
micromamba env export
micromamba env export > env.yaml
- name: Upload final environment as artifact
uses: actions/upload-artifact@v2
uses: actions/upload-artifact@v3
with:
name: env-${{ matrix.os }}-${{ matrix.python-version }}
path: env.yaml
Expand All @@ -72,7 +73,7 @@ jobs:
- name: Install coveralls and coverage
if: ${{ matrix.os == 'ubuntu-latest' }}
run: |
conda install -q -y coveralls=3.3.1 coverage pytest-cov
micromamba install -q -y coveralls=3.3.1 coverage pytest-cov
- name: Run linux tests
if: ${{ matrix.os == 'ubuntu-latest' }}
env:
Expand Down Expand Up @@ -107,77 +108,28 @@ jobs:
env:
PKG_NAME: "activity-browser-dev"
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Build and deploy 3.8
uses: conda-incubator/setup-miniconda@v2
with:
python-version: 3.8
activate-environment: build
environment-file: ci/conda-envs/build.yml
environment-file: .github/conda-envs/build.yml
- name: Export version
run: |
echo "VERSION=$(date +'%Y.%m.%d')" >> $GITHUB_ENV
- name: Patch recipe with run requirements from stable
uses: mikefarah/yq@master
# Adds the run dependencies from the stable recipe to the dev recipe (inplace)
# Also adds the dependecies to the ab_dev environment file
with:
cmd: |
yq eval-all -i 'select(fi == 0).requirements.run += select(fi == 1).requirements.run | select(fi == 0)' ci/recipe/dev/meta.yaml ci/recipe/stable/meta.yaml
yq eval-all -i 'select(fi == 0).dependencies += select(fi == 1).requirements.run | select(fi == 0)' ci/conda-envs/ab_dev.yml ci/recipe/stable/meta.yaml
yq eval-all -i 'select(fi == 0).requirements.run += select(fi == 1).requirements.run | select(fi == 0)' .github/dev-recipe/meta.yaml recipe/meta.yaml
- name: Show patched dev recipe
run: cat ci/recipe/dev/meta.yaml
- name: Build development package
run: |
conda build ci/recipe/dev
- name: Upload the activity-browser-dev package and env
run: |
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload --force \
/usr/share/miniconda/envs/build/conda-bld/noarch/*.tar.bz2
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload ci/conda-envs/ab_dev.yml


deploy-arm:
# Make sure to only run a deploy if all tests pass.
needs:
- tests
# And only on a push event, not a pull_request.
if: ${{ github.event_name == 'push' }}
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}
env:
PKG_NAME: "activity-browser-arm"
steps:
- uses: actions/checkout@v2
- name: Build and deploy 3.8
uses: conda-incubator/setup-miniconda@v2
with:
python-version: 3.8
activate-environment: build
environment-file: ci/conda-envs/build.yml
- name: Export version
run: |
echo "VERSION=$(date +'%Y.%m.%d')" >> $GITHUB_ENV
- name: Patch recipe with run requirements from stable
uses: mikefarah/yq@master
# Adds the run dependencies from the stable recipe to the arm recipe
# drop brightway2, but add brightway2_nosolver and scikit-umfpack
# Also adds the dependecies to the ab_arm environment file
with:
cmd: |
yq e '.requirements.run.[] | select(. != "brightway2*") | [.]' ci/recipe/stable/meta.yaml > arm_requirements.yaml
yq e -i '. += ["brightway2_nosolver", "scikit-umfpack"]' arm_requirements.yaml
yq eval-all -i 'select(fi == 0).requirements.run += select(fi == 1) | select(fi == 0)' ci/recipe/arm/meta.yaml arm_requirements.yaml
yq eval-all -i 'select(fi == 0).dependencies += select(fi == 1) | select(fi == 0)' ci/conda-envs/ab_arm.yml arm_requirements.yaml
- name: Show patched arm recipe
run: cat ci/recipe/arm/meta.yaml
run: cat .github/dev-recipe/meta.yaml
- name: Build development package
run: |
conda build ci/recipe/arm
- name: Upload the activity-browser-arm package and env
conda build .github/dev-recipe/
- name: Upload the activity-browser-dev package
run: |
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload --force \
/usr/share/miniconda/envs/build/conda-bld/noarch/*.tar.bz2
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload ci/conda-envs/ab_arm.yml
17 changes: 5 additions & 12 deletions .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,37 +11,30 @@ jobs:
run:
shell: bash -l {0}
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- name: Build changelog from PRs with labels
id: build_changelog
uses: mikepenz/release-changelog-builder-action@v2
uses: mikepenz/release-changelog-builder-action@v4
with:
configuration: "ci/changelog-configuration.json"
configuration: ".github/changelog-configuration.json"
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Patch ab env with run requirements from stable recipe
uses: mikefarah/yq@master
with:
cmd: |
yq eval-all -i 'select(fi == 0).dependencies += select(fi == 1).requirements.run | select(fi == 0)' ci/conda-envs/ab.yml ci/recipe/stable/meta.yaml
- name: Create github release
uses: ncipollo/release-action@v1
with:
body: ${{steps.build_changelog.outputs.changelog}}
artifacts: 'ci/conda-envs/ab.yml'
commit: master
token: ${{ secrets.GITHUB_TOKEN }}
- name: Set up conda-build environment
uses: conda-incubator/setup-miniconda@v2
with:
python-version: 3.8
activate-environment: build
environment-file: ci/conda-envs/build.yml
environment-file: .github/conda-envs/build.yml
- name: Build activity-browser stable
run: |
conda build ci/recipe/stable
conda build recipe/
- name: Upload to anaconda.org
run: |
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload \
/usr/share/miniconda/envs/build/conda-bld/noarch/*.tar.bz2
anaconda -t ${{ secrets.CONDA_UPLOAD_TOKEN }} upload ci/conda-envs/ab.yml
Loading