Update derived variables default for inputs

Use `$grey-darker` and `$grey` as default instead of `$text-strong` and `$text-light` which may contain the "inherit" value (jgthms#2741)
marcbelletre · Dec 17, 2019 · 7015d30 · 7015d30
1 parent 5381f26
commit 7015d30
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 11 deletions.
diff --git a/css/bulma.css.map b/css/bulma.css.map
diff --git a/docs/_data/variables/form/shared.json b/docs/_data/variables/form/shared.json
@@ -2,7 +2,7 @@
   "by_name": {
     "$input-color": {
       "name": "$input-color",
-      "value": "$text-strong",
+      "value": "$grey-darker",
       "type": "variable",
       "computed_type": "color",
       "computed_value": "hsl(0, 0%, 21%)"
@@ -38,7 +38,7 @@
     },
     "$input-hover-color": {
       "name": "$input-hover-color",
-      "value": "$text-strong",
+      "value": "$grey-darker",
       "type": "variable",
       "computed_type": "color",
       "computed_value": "hsl(0, 0%, 21%)"
@@ -52,7 +52,7 @@
     },
     "$input-focus-color": {
       "name": "$input-focus-color",
-      "value": "$text-strong",
+      "value": "$grey-darker",
       "type": "variable",
       "computed_type": "color",
       "computed_value": "hsl(0, 0%, 21%)"
@@ -76,7 +76,7 @@
     },
     "$input-disabled-color": {
       "name": "$input-disabled-color",
-      "value": "$text-light",
+      "value": "$grey",
       "type": "variable",
       "computed_type": "color",
       "computed_value": "hsl(0, 0%, 48%)"
@@ -152,4 +152,4 @@
     "$input-radius"
   ],
   "file_path": "form/shared.sass"
-}
+}
diff --git a/sass/form/shared.sass b/sass/form/shared.sass
@@ -1,19 +1,19 @@
-$input-color: $text-strong !default
+$input-color: $grey-darker !default
 $input-background-color: $scheme-main !default
 $input-border-color: $border !default
 $input-height: $control-height !default
 $input-shadow: inset 0 0.0625em 0.125em rgba($scheme-invert, 0.05) !default
-$input-placeholder-color: rgba($input-color, 0.3) !default
+$input-placeholder-color: rgba($grey-darker, 0.3) !default
 
-$input-hover-color: $text-strong !default
+$input-hover-color: $grey-darker !default
 $input-hover-border-color: $border-hover !default
 
-$input-focus-color: $text-strong !default
+$input-focus-color: $grey-darker !default
 $input-focus-border-color: $link !default
 $input-focus-box-shadow-size: 0 0 0 0.125em !default
 $input-focus-box-shadow-color: rgba($link, 0.25) !default
 
-$input-disabled-color: $text-light !default
+$input-disabled-color: $grey !default
 $input-disabled-background-color: $background !default
 $input-disabled-border-color: $background !default
 $input-disabled-placeholder-color: rgba($input-disabled-color, 0.3) !default