Skip to content

Commit

Permalink
Bug 1900494 [wpt PR 46609] - Add checkmark to base-select options, a=…
Browse files Browse the repository at this point in the history
…testonly

Automatic update from web-platform-tests
Add checkmark to base-select options

This is being discussed in OpenUI here:
openui/open-ui#863

The discussion suggested that we should use a unicode checkmark instead
of an SVG, so that's what this patch does.

It might be better to use ::marker instead of ::before, but we might
also end up with something else entirely and I think that reusing
::marker would be harder to implement, so I am using ::before for now.

Bug: 1511354
Change-Id: I29c1dfc26208e6fc13cf42782a3d9d6fae2e711c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5578818
Reviewed-by: David Baron <dbaronchromium.org>
Commit-Queue: Joey Arhar <jarharchromium.org>
Cr-Commit-Position: refs/heads/main{#1313329}

--

wpt-commits: 56ec66da8735eb2ccbd9be689917b2b1aad6faed
wpt-pr: 46609

UltraBlame original commit: aecc64805ed6326a9941b62fdce414097d8abb42
  • Loading branch information
marco-c committed Jun 16, 2024
1 parent 4a88783 commit 120bfc5
Show file tree
Hide file tree
Showing 4 changed files with 221 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,173 @@
<
!
DOCTYPE
html
>
<
link
rel
=
author
href
=
"
mailto
:
jarhar
chromium
.
org
"
>
<
link
rel
=
help
href
=
"
https
:
/
/
github
.
com
/
openui
/
open
-
ui
/
issues
/
863
#
issuecomment
-
1769004174
"
>
<
script
src
=
"
/
resources
/
testharness
.
js
"
>
<
/
script
>
<
script
src
=
"
/
resources
/
testharnessreport
.
js
"
>
<
/
script
>
<
select
style
=
"
appearance
:
base
-
select
"
>
<
option
>
option
<
/
option
>
<
/
select
>
<
script
>
test
(
(
)
=
>
{
assert_equals
(
getComputedStyle
(
document
.
querySelector
(
'
option
'
)
'
:
:
before
'
)
.
content
"
\
u2713
"
/
"
"
)
;
}
'
appearance
:
base
-
select
options
should
have
a
checkmark
with
empty
alt
text
.
'
)
;
<
/
script
>
Original file line number Diff line number Diff line change
Expand Up @@ -319,6 +319,48 @@ stylable
-
select
-
option
:
:
before
{
content
:
'
\
2713
'
/
'
'
;
}
.
stylable
-
select
-
option
:
not
(
.
selected
)
:
:
before
{
visibility
:
hidden
;
}
.
stylable
-
select
-
button
{
color
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,14 @@
0
class
=
"
stylable
-
select
-
option
selected
"
>
<
span
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,14 @@
0
class
=
"
stylable
-
select
-
option
selected
"
>
one
<
Expand Down

0 comments on commit 120bfc5

Please sign in to comment.