Bug 1841505: postpone setting the popover invoker in the "show popove…

…r" algo. r=emilio See <whatwg/html#9383 (comment)>. Differential Revision: https://phabricator.services.mozilla.com/D182709 UltraBlame original commit: 0b5333b2ef93c5e4153ac198b577c6f54c5ad538
marco-c · Jul 16, 2023 · c7ff749 · c7ff749
1 parent cd82cd4
commit c7ff749
Show file tree

Hide file tree

Showing 4 changed files with 47 additions and 47 deletions.
diff --git a/dom/base/Element.cpp b/dom/base/Element.cpp
@@ -22514,6 +22514,10 @@ Element
 :
 GetTopmostPopoverAncestor
 (
+const
+Element
+*
+aInvoker
 )
 const
 {
@@ -22682,27 +22686,9 @@ GetFlattenedTreeParentElement
 )
 )
 ;
-RefPtr
-<
-Element
->
-invoker
-=
-newPopover
--
->
-GetPopoverData
-(
-)
--
->
-GetInvoker
-(
-)
-;
 checkAncestor
 (
-invoker
+aInvoker
 )
 ;
 return

diff --git a/dom/base/Element.h b/dom/base/Element.h
@@ -1805,16 +1805,14 @@ IsPopoverOpen
 )
 const
 ;
-mozilla
-:
-:
-dom
-:
-:
 Element
 *
 GetTopmostPopoverAncestor
 (
+const
+Element
+*
+aInvoker
 )
 const
 ;

diff --git a/dom/html/nsGenericHTMLElement.cpp b/dom/html/nsGenericHTMLElement.cpp
@@ -17183,7 +17183,7 @@ nsGenericHTMLElement
 :
 ShowPopoverInternal
 (
-nsGenericHTMLFormControlElementWithState
+Element
 *
 aInvoker
 ErrorResult
@@ -17193,26 +17193,6 @@ aRv
 {
 if
 (
-PopoverData
-*
-data
-=
-GetPopoverData
-(
-)
-)
-{
-data
--
->
-SetInvoker
-(
-aInvoker
-)
-;
-}
-if
-(
 !
 CheckPopoverValidity
 (
@@ -17241,6 +17221,25 @@ OwnerDoc
 MOZ_ASSERT
 (
 !
+GetPopoverData
+(
+)
+|
+|
+!
+GetPopoverData
+(
+)
+-
+>
+GetInvoker
+(
+)
+)
+;
+MOZ_ASSERT
+(
+!
 OwnerDoc
 (
 )
@@ -17379,6 +17378,7 @@ ancestor
 =
 GetTopmostPopoverAncestor
 (
+aInvoker
 )
 ;
 if
@@ -17516,9 +17516,16 @@ true
 true
 )
 ;
+{
+auto
+*
+popoverData
+=
 GetPopoverData
 (
 )
+;
+popoverData
 -
 >
 SetPopoverVisibilityState
@@ -17529,6 +17536,15 @@ PopoverVisibilityState
 Showing
 )
 ;
+popoverData
+-
+>
+SetInvoker
+(
+aInvoker
+)
+;
+}
 FocusPopover
 (
 )

diff --git a/dom/html/nsGenericHTMLElement.h b/dom/html/nsGenericHTMLElement.h
@@ -1070,7 +1070,7 @@ MOZ_CAN_RUN_SCRIPT
 void
 ShowPopoverInternal
 (
-nsGenericHTMLFormControlElementWithState
+Element
 *
 aInvoker
 ErrorResult