forked from kyma-project/kyma
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the Application Broker with the Knative Eventing mesh #2028
Draft
marcobebway
wants to merge
19
commits into
knative-event-mesh-integration
Choose a base branch
from
application-broker-event-mesh-dev
base: knative-event-mesh-integration
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Integrate the Application Broker with the Knative Eventing mesh #2028
marcobebway
wants to merge
19
commits into
knative-event-mesh-integration
from
application-broker-event-mesh-dev
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires downgrade of service-catalog and kyma (application-operator) Remove all unnecessary dep constraints
Provision tests still missing/failing
antoineco
reviewed
Nov 22, 2019
components/application-broker/internal/broker/deprovision_test.go
Outdated
Show resolved
Hide resolved
components/application-broker/internal/broker/provision_test.go
Outdated
Show resolved
Hide resolved
marcobebway
force-pushed
the
application-broker-event-mesh-dev
branch
from
November 22, 2019 15:35
968ee15
to
3320f3b
Compare
marcobebway
force-pushed
the
application-broker-event-mesh-dev
branch
from
November 22, 2019 15:40
3320f3b
to
3fdb94b
Compare
Useless, actions are recorded before objects are mutates by reactors, so Name is empty in the recorded action.
antoineco
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Integrate the Application Broker with the Knative Eventing mesh:
Provisioning
Deprovisioning
Related issue(s)