Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server call docs and increase code coverage #41

Merged
merged 9 commits into from
Mar 19, 2019

Conversation

marcoferrer
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@7097cbb). Click here to learn what that means.
The diff coverage is 62.96%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #41   +/-   ##
==========================================
  Coverage           ?   85.77%           
  Complexity         ?       10           
==========================================
  Files              ?       12           
  Lines              ?      239           
  Branches           ?       27           
==========================================
  Hits               ?      205           
  Misses             ?       24           
  Partials           ?       10
Impacted Files Coverage Δ Complexity Δ
...oferrer/krotoplus/coroutines/GrpcContextElement.kt 100% <ø> (ø) 4 <0> (?)
...rrer/krotoplus/coroutines/client/ClientChannels.kt 100% <ø> (ø) 0 <0> (?)
...errer/krotoplus/coroutines/CoroutineCallOptions.kt 100% <ø> (ø) 0 <0> (?)
...ferrer/krotoplus/coroutines/server/ServiceScope.kt 0% <0%> (ø) 0 <0> (?)
...oferrer/krotoplus/coroutines/server/ServerCalls.kt 84.48% <45.45%> (ø) 0 <0> (?)
.../marcoferrer/krotoplus/coroutines/call/CallExts.kt 71.64% <80%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7097cbb...324f934. Read the comment docs.

@marcoferrer marcoferrer merged commit a1129f6 into develop Mar 19, 2019
@marcoferrer marcoferrer deleted the server-call-docs-and-coverage branch March 19, 2019 03:49
marcoferrer added a commit that referenced this pull request Apr 3, 2019
* add default impl to ServiceScope.initialContext

* remove deprecated apis

* improve api docs

* increase server call code coverage

* add server call server streaming tests

* add server call bidi streaming tests

* add codecov to travis config

* limit codecov check to coroutines module

* update readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants