Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race in client cancellation propagation #98

Merged
merged 3 commits into from
Dec 26, 2019

Conversation

marcoferrer
Copy link
Owner

@marcoferrer marcoferrer commented Dec 26, 2019

Address race condition when prematurely cancelling a call via closing its outbound channel.

Issue reported in #93

@codecov
Copy link

codecov bot commented Dec 26, 2019

Codecov Report

Merging #98 into master will increase coverage by 0.67%.
The diff coverage is 64.7%.

Impacted file tree graph

@@             Coverage Diff             @@
##             master     #98      +/-   ##
===========================================
+ Coverage     86.53%   87.2%   +0.67%     
  Complexity       19      19              
===========================================
  Files            15      15              
  Lines           312     344      +32     
  Branches         53      47       -6     
===========================================
+ Hits            270     300      +30     
- Misses           15      26      +11     
+ Partials         27      18       -9
Impacted Files Coverage Δ Complexity Δ
...ithub/marcoferrer/krotoplus/coroutines/RpcUtils.kt 92.3% <ø> (+29.8%) 0 <0> (ø) ⬇️
...us/coroutines/client/ClientStreamingCallChannel.kt 81.81% <100%> (+4.04%) 0 <0> (ø) ⬇️
...oferrer/krotoplus/coroutines/server/ServerCalls.kt 87.2% <100%> (+5.5%) 0 <0> (ø) ⬇️
...rcoferrer/krotoplus/coroutines/call/FlowControl.kt 72.91% <45%> (-16.28%) 0 <0> (ø)
...otoplus/coroutines/client/ClientBidiCallChannel.kt 96.66% <87.5%> (+1.01%) 0 <0> (ø) ⬇️
...rrer/krotoplus/coroutines/server/ServerChannels.kt 90% <0%> (+1.11%) 0% <0%> (ø) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c62ab8...da3ed11. Read the comment docs.

@marcoferrer marcoferrer force-pushed the fix-race-cancellation-propagation branch from 1427c9f to da3ed11 Compare December 26, 2019 22:17
@marcoferrer marcoferrer merged commit 3a75d61 into master Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant