Added remap config options #19
Conversation
|
will this PR allow to exclude files from coverage? |
|
Yes it will. |
|
This would be great to have! |
|
Ping @delasteve |
|
@oNaiPs sorry about the late reply on this one, I kind of forgot I offered to help maintain this module until I saw your ping 😞 I've requested one small change then I'm happy to merge + release this 😄 |
|
@mattlewis92 thanks. I don't see any request? |
| @@ -18,6 +18,7 @@ Add the plugin, reporter and reporter configuration in your `karma.conf.js`. | |||
| plugins: ['karma-remap-istanbul'], | |||
| reporters: ['progress', 'karma-remap-istanbul'], | |||
| remapIstanbulReporter: { | |||
| remapOptions: {} //additional remap options | |||
There was a problem hiding this comment.
Aren't you missing a comma at the end of this line (even though it's just a README)?
| @@ -52,7 +53,9 @@ var KarmaRemapIstanbul = function (baseReporterDecorator, logger, config) { | |||
| })(); | |||
|
|
|||
| var sourceStore = istanbul.Store.create('memory'); | |||
| var collector = remap(unmappedCoverage, { sources: sourceStore }); | |||
| remapOptions.sources = sourceStore; | |||
There was a problem hiding this comment.
Can you change this to use object.assign so that the original remapOptions object isn't modified? Other than that LGTM.
|
Oops, sorry I'm not used to githubs review feature, I didn't submit the review |
|
@oNaiPs would it be possible for you to rebase this PR on master so it can be merged? |
|
Yes, I'll just make the changes you suggested and will push |
|
@mattlewis92 should be ready. Let me know if it works for you. |
|
Perfect, thanks @oNaiPs ! Released as 0.3.0 😃 |
No description provided.