Fix number filter for comparison with zero (#787)

Co-authored-by: st4ng <[email protected]>
marcusolsson · Feb 12, 2024 · 86ba1dd · 86ba1dd
1 parent 0f8c05d
commit 86ba1dd
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/src/ui/app/filterFunctions.ts b/src/ui/app/filterFunctions.ts
@@ -5,6 +5,7 @@ import {
   type DataRecord,
   type DataValue,
   type Optional,
+  isNumber,
   isOptionalString,
   isOptionalNumber,
   isOptionalBoolean,
@@ -113,10 +114,10 @@ export const numberFns: Record<
 > = {
   eq: (left, right) => left === right,
   neq: (left, right) => left !== right,
-  lt: (left, right) => (left && right ? left < right : false),
-  gt: (left, right) => (left && right ? left > right : false),
-  lte: (left, right) => (left && right ? left <= right : false),
-  gte: (left, right) => (left && right ? left >= right : false),
+  lt: (left, right) => isNumber(left) && isNumber(right) && left < right,
+  gt: (left, right) => isNumber(left) && isNumber(right) && left > right,
+  lte: (left, right) => isNumber(left) && isNumber(right) && left <= right,
+  gte: (left, right) => isNumber(left) && isNumber(right) && left >= right,
 };
 
 export const booleanFns: Record<