Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] attempting fix for ws protocol #2882

Open
wants to merge 2 commits into
base: ms/mpl-proxy-middleware
Choose a base branch
from

Conversation

maxtheman
Copy link
Contributor

📝 Summary

Fork of https://github.com/marimo-team/marimo/pull/2875/files with the same intention.

I think all that was needed was to forward the WebSocket connection directly to the Proxied Starlet app Instead of trying to Create a new WebSocket connection.

These tests pass, but I haven't yet had a chance to try it in a production app just to validate. I think it would also be handy to add HTTPS testing since that caused the original error.

🔍 Description of Changes

Adds ProxyMiddleWare and proxies mpl starlette app.

📋 Checklist

  • [x ] I have read the contributor guidelines.
  • [ x] For large changes, or changes that affect the public API: this change was discussed or approved through an issue, on Discord, or the community discussions (Please provide a link if applicable).
  • [ x] I have added tests for the changes made.
  • I have run the code and verified that it works as expected.

📜 Reviewers

@mscolnick

Copy link

vercel bot commented Nov 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
marimo-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 8:55pm
marimo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 8:55pm

Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant