[WIP] attempting fix for ws protocol #2882
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Fork of https://github.com/marimo-team/marimo/pull/2875/files with the same intention.
I think all that was needed was to forward the WebSocket connection directly to the Proxied Starlet app Instead of trying to Create a new WebSocket connection.
These tests pass, but I haven't yet had a chance to try it in a production app just to validate. I think it would also be handy to add HTTPS testing since that caused the original error.
🔍 Description of Changes
Adds
ProxyMiddleWare
and proxies mpl starlette app.📋 Checklist
📜 Reviewers
@mscolnick