-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose normalizeUIString #3178
Expose normalizeUIString #3178
Commits on Aug 19, 2016
-
Allow childViews to be already rendered and attached
If you were to override `buildChildView` instantiating the childViews with an `el` then you can create a collectionView from pre-rendered DOM
Configuration menu - View commit details
-
Copy full SHA for 1312114 - Browse repository at this point
Copy the full SHA 1312114View commit details -
Move setElement to the views from the mixin
CollectionView can’t be initially “rendered” because it does its initialization of many things on first render.
Configuration menu - View commit details
-
Copy full SHA for fe6aa19 - Browse repository at this point
Copy the full SHA fe6aa19View commit details
Commits on Aug 21, 2016
-
when a collection view is DOM * and it's not attached to the document ** should have _isAttached set to false * and it's attached to the document ** should have _isAttached set to true when rendering a childView * should not render childView twice
Configuration menu - View commit details
-
Copy full SHA for 5d74ec1 - Browse repository at this point
Copy the full SHA 5d74ec1View commit details
Commits on Aug 24, 2016
-
when a collection view is DOM * and it's not attached to the document ** should have a child view without `_isAttached` * and it's attached to the document ** should have a child view with `_isAttached` set to `true`
Configuration menu - View commit details
-
Copy full SHA for 5034c32 - Browse repository at this point
Copy the full SHA 5034c32View commit details
Commits on Aug 30, 2016
-
Merge pull request marionettejs#3135 from marionettejs/pjf/collection…
…view-iso Allow CollectionView to be populated with pre-rendered DOM
Configuration menu - View commit details
-
Copy full SHA for 8d41fc5 - Browse repository at this point
Copy the full SHA 8d41fc5View commit details
Commits on Aug 31, 2016
-
This function removes the need for a `preventDestroy` option. Essentially if you want to `preventDestroy` just detach the view first. When you want to preventDestroy you already have to have a copy of the view.. and depending on what is doing the view emptying `preventDestroy` can become a round about API. What you really want is ```js const myView = myRegion.currentView; myRegion.detachView(); myOtherRegion.show(myView); ```
Configuration menu - View commit details
-
Copy full SHA for ba4c9d7 - Browse repository at this point
Copy the full SHA ba4c9d7View commit details
Commits on Sep 1, 2016
-
Optimize triggerMethod, mergeOptions and hot handles (marionettejs#3144)
* mergeOptions src/common/merge-options.js * iterate through `keys` and merge instead of getting the `keys` from options, then merging monitor-view-events src/common/monitor-view-events.js * Define once: triggerDOMRefresh handleBeforeAttach handleAttach handleBeforeDetach handleDetach handleRender triggerMethodOn src/common/trigger-method.js * Distinct if `context` has triggerMethod, use and return result with fallback to helper function and return result CollectionView src/collection-view.js * private childViewEventHandle for optimization * _proxyChildEvents using childViewEventHandle src/common/trigger-method.js * will remember the last `event` name transform src/mixins/behaviors.js takes arraylike value only src/mixins/view.js triggerMethod only passes along `arguments` other functions * Make trigger on behavior follow same patterns as parent * Make childViewEventHandler a common module
Configuration menu - View commit details
-
Copy full SHA for 61d20b6 - Browse repository at this point
Copy the full SHA 61d20b6View commit details
Commits on Sep 2, 2016
-
Configuration menu - View commit details
-
Copy full SHA for ecd894b - Browse repository at this point
Copy the full SHA ecd894bView commit details -
CollectionView and CompositeView removing views performance update. (m…
…arionettejs#3105) * CollectionView# and CompositeView# _initialEvents * Listen to `this.collection~event:update` instead. _onCollectionUpdate * pass `options.changed.removed` to `this._removeChildViews` * updated test to reflect additions _removeChildViews * use array of models to determine what views to remove if not already destroyed. * Support `checkEmpty` for preventing empty collection checking _destroyChildren * checks to see if there are any children to destroy before calling `_removeChildViews` removeChildView * using _destroyChildView * added test for trying to remove falsy and valid values _getRemovedViews _removeChildView - ~~~_onCollectionRemove~~~ * test and references removed _findGreatestIndexedView * finds the view with the greatest `_index` and returns it. _updateIndices * accepts array of views for _findGreatestIndexedView [test] when removing the sorted view, the `view._index` should update. * Attempts to always use models instead of modelOrViews This may not be helpful.. just wanted to give it one last show. I don’t think there are perf issues. particularly since `findByModel` is cheap. In fact I think the complexity of reorder went down.. though I didn’t test it..
Configuration menu - View commit details
-
Copy full SHA for 4396132 - Browse repository at this point
Copy the full SHA 4396132View commit details
Commits on Sep 3, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 57eab1f - Browse repository at this point
Copy the full SHA 57eab1fView commit details
Commits on Sep 4, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 59124d3 - Browse repository at this point
Copy the full SHA 59124d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84ebc1d - Browse repository at this point
Copy the full SHA 84ebc1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 53a1611 - Browse repository at this point
Copy the full SHA 53a1611View commit details
Commits on Sep 5, 2016
-
Merge pull request marionettejs#4 from rafde/region-detachview-detach…
…ChildView Region detachview detach child view
Configuration menu - View commit details
-
Copy full SHA for 3f4e701 - Browse repository at this point
Copy the full SHA 3f4e701View commit details
Commits on Sep 7, 2016
-
CollectionView and CompositeView rendering views performance increase (…
…marionettejs#3113) * _createView * creates view from model and does event monitor and proxyChild events _renderChildView * render views and triggers render events _setupChildView * sets child view properties: parent, _index (conditionally), monitorViewEvents, and _proxyChildEvents. * CollectionView addChildView * using `_setupChildView` * triggers `event~before:add:child` * triggers `event~add:child` * when buffering, will add view to list of children but will not update children length for performance increase * using `_renderView` ~~_addChildView~~ _updateIndices * removed need to pass index _addChild * removed passing ChildView param * using `_createView` _onCollectionAdd * using `_addChild` _showCollection * using `_addChild` * calls `children._updateLength` _showEmptyView * removed unnecessary `view._parent` setting
Configuration menu - View commit details
-
Copy full SHA for cffeb86 - Browse repository at this point
Copy the full SHA cffeb86View commit details -
Merge pull request marionettejs#3155 from paulfalgout/region-detachview
Make a public detachView
Configuration menu - View commit details
-
Copy full SHA for 8c36b65 - Browse repository at this point
Copy the full SHA 8c36b65View commit details
Commits on Sep 13, 2016
-
Expose normalizeUIString, to parallel normalizeUIKeys and normalizeUIValues, issue marionettejs#3174.
Configuration menu - View commit details
-
Copy full SHA for b129a02 - Browse repository at this point
Copy the full SHA b129a02View commit details