Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose normalizeUIString #3179

Merged
merged 2 commits into from
Sep 14, 2016

Conversation

bazineta
Copy link
Contributor

Expose normalizeUIString.

Link to the issue: #3174

Expose normalizeUIString, to parallel normalizeUIKeys and
normalizeUIValues. Issue marionettejs#3174.
@bazineta bazineta changed the base branch from master to next September 13, 2016 14:53
@paulfalgout
Copy link
Member

👏 thanks. This is gonna need some docs and specs too.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 99.845% when pulling 90b62bc on bazineta:expose-normalizeUIString into 8c36b65 on marionettejs:next.

Update test coverage to handle normalizeUIString.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e865820 on bazineta:expose-normalizeUIString into 8c36b65 on marionettejs:next.

@paulfalgout
Copy link
Member

👍

@belackriv
Copy link

👍
Thanks @bazineta

@rafde
Copy link
Member

rafde commented Sep 14, 2016

good to merge without the docs?
@paulfalgout ?
if so, 👍
otherwise, waiting on doc update.

@rafde rafde added this to the v3.x milestone Sep 14, 2016
@paulfalgout paulfalgout merged commit 6931145 into marionettejs:next Sep 14, 2016
@paulfalgout paulfalgout modified the milestones: v3.1, v3.x Sep 14, 2016
paulfalgout pushed a commit to paulfalgout/backbone.marionette that referenced this pull request Sep 26, 2016
* Expose normalizeUIString

Expose normalizeUIString, to parallel normalizeUIKeys and
normalizeUIValues. Issue marionettejs#3174.

* Add normalizeUIString unit test

Update test coverage to handle normalizeUIString.
paulfalgout pushed a commit to paulfalgout/backbone.marionette that referenced this pull request Oct 12, 2016
* Expose normalizeUIString

Expose normalizeUIString, to parallel normalizeUIKeys and
normalizeUIValues. Issue marionettejs#3174.

* Add normalizeUIString unit test

Update test coverage to handle normalizeUIString.
ahumphreys87 pushed a commit that referenced this pull request Oct 13, 2016
* Expose normalizeUIString

Expose normalizeUIString, to parallel normalizeUIKeys and
normalizeUIValues. Issue #3174.

* Add normalizeUIString unit test

Update test coverage to handle normalizeUIString.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants