Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imports JSON when generating results #286

Merged
merged 2 commits into from
Nov 24, 2019
Merged

Imports JSON when generating results #286

merged 2 commits into from
Nov 24, 2019

Conversation

PowerSchill
Copy link
Contributor

@PowerSchill PowerSchill commented Nov 23, 2019 •
edited
Loading

Description

This resolves the issue where mdl was crashing when using json output with a configuration file.

Related Issues

Closes issue #285

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (non-breaking change that does not add functionality but updates documentation)
  • Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

  • I have read the CONTRIBUTING document.
  • Wrote good commit messages
  • Feature branch is up-to-date with master, if not - rebase it
  • Added tests for all new/changed functionality, including tests for positive and negative scenarios
  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences

jaymzh
jaymzh requested changes Nov 23, 2019
View reviewed changes
lib/mdl.rb Show resolved Hide resolved
@jaymzh
Copy link
Member

jaymzh commented Nov 24, 2019

Thanks!

@jaymzh jaymzh merged commit ddf8829 into markdownlint:master Nov 24, 2019
@PowerSchill PowerSchill deleted the json_fix branch November 24, 2019 12:56
@jaymzh jaymzh mentioned this pull request Nov 24, 2019
Merged
10 tasks
jaymzh added a commit to jaymzh/markdownlint that referenced this pull request Nov 24, 2019
@jaymzh
Add tests for json output
975148e 
I added the JSON formatter in markdownlint#206, then in response to markdownlint#223, limited
where the JSON module was included in markdownlint#231, but unknowingly broke JSON output.
@PowerSchill recently fixed that in markdownlint#286... but all this should have a test
around it, so this adds tests.

Signed-off-by: Phil Dibowitz <[email protected]>
NaomiReeves pushed a commit that referenced this pull request Nov 25, 2019
@jaymzh @NaomiReeves
Add tests for json output (#288)
d514591 
I added the JSON formatter in #206, then in response to #223, limited
where the JSON module was included in #231, but unknowingly broke JSON output.
@PowerSchill recently fixed that in #286... but all this should have a test
around it, so this adds tests.

Signed-off-by: Phil Dibowitz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymzh jaymzh jaymzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PowerSchill @jaymzh