fix: fix quadratic execution in em mask (#2818)

* fix: fix redos in em mask * also remove (
markedjs · May 26, 2023 · a37fe8e · a37fe8e · vercel · May 26, 2023
1 parent 46f4e5c
commit a37fe8e
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 3 deletions.
diff --git a/src/rules.js b/src/rules.js
@@ -187,7 +187,7 @@ inline._punctuation = '!"#$%&\'()+\\-.,/:;<=>?@\\[\\]`^{|}~';
 inline.punctuation = edit(inline.punctuation).replace(/punctuation/g, inline._punctuation).getRegex();
 
 // sequences em should skip over [title](link), `code`, <html>
-inline.blockSkip = /\[[^\]]*?\]\([^\)]*?\)|`[^`]*?`|<[^>]*?>/g;
+inline.blockSkip = /\[[^[\]]*?\]\([^\(\)]*?\)|`[^`]*?`|<[^<>]*?>/g;
 // lookbehind is not available on Safari as of version 16
 // inline.escapedEmSt = /(?<=(?:^|[^\\)(?:\\[^])*)\\[*_]/g;
 inline.escapedEmSt = /(?:^|[^\\])(?:\\\\)*\\[*_]/g;

diff --git a/test/helpers/load.js b/test/helpers/load.js
@@ -111,9 +111,10 @@ export function loadFiles(dir) {
         return obj;
     }
 
-    for (const spec of specs) {
+    for (let i = 0; i < specs.length; i++) {
+      const spec = specs[i];
       if (!spec.section) {
-        spec.section = name;
+        spec.section = `${name}[${i}]`;
       }
       if (!obj[spec.section]) {
         obj[spec.section] = {

diff --git a/test/specs/redos/quadratic_em_mask.cjs b/test/specs/redos/quadratic_em_mask.cjs
@@ -0,0 +1,18 @@
+module.exports = [
+  {
+    markdown: '['.repeat(100000),
+    html: `<p>${'['.repeat(100000)}</p>`
+  },
+  {
+    markdown: '[.'.repeat(50000),
+    html: `<p>${'[.'.repeat(50000)}</p>`
+  },
+  {
+    markdown: '<'.repeat(100000),
+    html: `<p>${'<'.repeat(100000)}</p>`
+  },
+  {
+    markdown: '<.'.repeat(50000),
+    html: `<p>${'<.'.repeat(50000)}</p>`
+  }
+];