Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of startsWith and endsWith breaks IE11 #1876

Closed
Labels

Comments

@jhildenbiddle
Copy link
Contributor

Marked version: 1.2.6 (not sure when change was introduced)

Describe the bug
The use of startsWith and endsWith in the source breaks IE11

To Reproduce

  1. Launch IE11
  2. Open Developer Tools
  3. Click on Console tab
  4. Visit https://docsify.js.org (which uses marked 1.2.6)
  5. Note error message

Expected behavior
Expected marked to continue to work in IE11 until support is officially dropped in a future major version.

@jhildenbiddle jhildenbiddle changed the title Use of startsWith and endsWith bread IE11 Use of startsWith and endsWith breaks IE11 Dec 14, 2020
jhildenbiddle added a commit to jhildenbiddle/marked that referenced this issue Dec 14, 2020
github-actions bot pushed a commit that referenced this issue Dec 15, 2020
## [1.2.7](v1.2.6...v1.2.7) (2020-12-15)

### Bug Fixes

* Replace use of startsWith and endsWith with regex for IE11 ([#1877](#1877)) ([4fdde20](4fdde20)), closes [#1876](#1876)
@github-actions
Copy link

🎉 This issue has been resolved in version 1.2.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment