Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code blocks]: Consolidate issues #983

Closed
joshbruce opened this issue Dec 25, 2017 · 5 comments
Closed

[Code blocks]: Consolidate issues #983

joshbruce opened this issue Dec 25, 2017 · 5 comments
Labels
category: code blocks epic A large goal or objective for a major release.
Milestone

Comments

@joshbruce
Copy link
Member

This issue consolidates reference to issues and PRs related to code blocks. Issues will be closed, PRs will be left open, if no merge conflicts exist. See #956

@joshbruce joshbruce added the L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue label Dec 25, 2017
@joshbruce joshbruce added this to the 0.4.0 - No known defects milestone Dec 25, 2017
This was referenced Dec 25, 2017
@mercmobily
Copy link

Josh, this means that all of these issues are still valid and unresolved, even though they are marked as "closed". Right?

@joshbruce
Copy link
Member Author

Pretty much. Given the issues span 5+ years I figured this was a good way to put them in one place to maybe put a checklist together to say, "We have tests in the current codebase that demonstrate this is no longer a problem." (I think the community was getting overwhelmed by the sheer number of open issues and maybe not knowing where to begin to contribute back.)

So, if you're looking to contribute, it might be pretty simple. If there's no test to measure the validity - then, it's not resolved - so, it may be as simple as writing a test, verifying it passes, then submitting the PR. If there's a test already - then we can remove it from the reference list.

Hope that makes sense.

@joshbruce
Copy link
Member Author

@mercmobily: Shorter version. I don't know if they're resolved or not. Kinda hoping the community will help out on that score. One or two people can't do all the heavy lifting...as has been evidenced. So, I'm taking a somewhat different tack with things. :)

@jmduke
Copy link

jmduke commented Dec 26, 2017

I'm not sure if this is helpful (and I'd be happy to delete the comment if not), but here's a base case of how marked differs from most implementations:

https://johnmacfarlane.net/babelmark2/?text=%3Ch1%3ETest%3C%2Fh1%3E%0A++++++++++++%3Cp%3EShould+this+code+be+in+a+pre+block%3F%3C%2Fp%3E

This has bit me a couple times and I couldn't find specific settings that would resolve it (and though babelmark is testing against 0.2.6 I'm seeing the same behavior on 0.3.9.)

@Feder1co5oave
Copy link
Contributor

Feder1co5oave commented Jan 10, 2018

@joshbruce joshbruce added the good first issue Something easy to get started with label Feb 28, 2018
@joshbruce joshbruce removed this from the 0.4.0 - No known defects milestone Apr 4, 2018
@joshbruce joshbruce added epic A large goal or objective for a major release. and removed L2 - annoying Similar to L1 - broken but there is a known workaround available for the issue labels Apr 4, 2018
@joshbruce joshbruce added this to the v0.x milestone Apr 4, 2018
@joshbruce joshbruce removed the good first issue Something easy to get started with label Apr 9, 2018
@UziTech UziTech closed this as completed Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: code blocks epic A large goal or objective for a major release.
Projects
None yet
Development

No branches or pull requests

5 participants