fix backticks in inline code (replaces #503, fixes #312) #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2018
UziTech
reviewed
Feb 19, 2018
| @@ -664,7 +664,7 @@ InlineLexer.prototype.output = function(src) { | |||
| // code | |||
| if (cap = this.rules.code.exec(src)) { | |||
| src = src.substring(cap[0].length); | |||
| out += this.renderer.codespan(escape(cap[2].trim(), true)); | |||
| out += this.renderer.codespan(escape(cap[3].trim(), true)); | |||
There was a problem hiding this comment.
@Feder1co5oave @joshbruce We have to watch out for changing capturing parentheses. This can be a breaking change. https://github.com/firede/msee/pull/59/files
This was referenced Feb 19, 2018
Closed
|
They actually re-wrote the parser, while using its internal regex rules, so I maintain this should not be considered a breaking change as suggested in #1059 |
joshbruce
added a commit
that referenced
this pull request
Feb 19, 2018
revert number of capturing parens in #1013
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
fix backticks in inline code (replaces markedjs#503, fixes markedjs#312)
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
zhenalexfan
pushed a commit
to zhenalexfan/MarkdownHan
that referenced
this pull request
Nov 8, 2021
revert number of capturing parens in markedjs#1013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #312:
Tests are about checking for whitespace, which is ignored by our test system for now.