-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Marked Defibrillator Challenge (alpha) #1107
Conversation
Could require an update to a "News" file as part of each PR; Travis can check for this. That's what cpython (implementation of Python) does. |
Yes. My regex paper is due in a week though so I'm laying low. |
Fair. And good luck! |
|
||
In case you haven't noticed, and judging by attendance you haven't… (Movie. Major League. No? Anyway.) | ||
|
||
In case you haven't noticed, after years of [being mostly dead](https://github.com/markedjs/marked/issues/1106) (not to be confused with stable), Marked is trying to come back to life. We're about at the "You just wiggled your finger" stage ([The Princess Bride](https://youtu.be/yokQ0_8__ts). No? Come on!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not the biggest fan of the conversation fluff. It makes me take the project less seriously.
|
||
There are four of us on the core team and we have one curious contributor helping us make moves (see [AUTHORS](https://github.com/markedjs/marked/blob/master/AUTHORS.md) page). | ||
|
||
We've stirred the tanks a bit and, Houston, we have a problem. ([Apollo 13](https://youtu.be/Bti9_deF5gs). No? Where have y'all been!? Seriously, we haven't talked in a while, where have you been? Oh, right, better question, where has the *marked* community been? Again, mostly dead…) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still trying to figure out if there's anything important in this README...
I like the idea of inviting people to add simple test cases, but I think the description is a bit noisy. Maybe make it a bit more concise before we commit it. I think it's good for projects to be fun and casual, but this is a bit over the top for me. So our number one priority is to be 100% CommonMark compliant for 1.0? |
@intcreator: Want to wait for more feedback before responding further. Check out the CommonMark Compliance project and description (or let me know if you can't see it) and related epic (#1109) regarding priority. Think this is more information gathering and getting help from our friends in that endeavor. |
I get the same feeling with a lot of the docs. |
@intcreator and @styfle: Thank you for the feedback. In all honesty, I could be overcompensating. I'm a pretty big believer in Conway's Law - probably why I focus a lot on the "individuals and interactions" piece of Agile Software Development. So, let me ask the question - especially, but not limited to @intcreator and @davisjam:
Note: I've read literally hundreds of issues and PRs and have a pretty decent understanding of the history of the community for the project, I think...that's why I don't remember seeing a lot of these names or faces there. [edit] Also might be why I could be overcompensating with the relaxed or "not so serious" side of things. |
Also, by approving this via review, we are not committing to a merge...only me tagging a bunch of folks as a first wave test case. (Just want to be clear.) |
Maybe this LOTR reference would be more appropriate... https://youtu.be/jDBPmEAheCY - granted, given what the community devolved into...not sure where the marked brand stands right now. |
Closing. Scaling too soon. |
I started looking at Marked because I'm using Polymer's Because the cost is so high, I may instead create my own Polymer element that implements the Commonmark.js parser. If it works, then I'll start focusing more on my web audio API project again. This leads me to a question—is there anything that Marked does that Commonmark.js doesn't? |
@intcreator Yes. I don't believe commonmark.js supports GitHub Flavored Markdown (GFM) |
Marked version: 0.3.17
Description
We don't actually know how many users we really have. Our contributors have kinda bailed on us. This should help us gauge interest beyond the core team in keeping marked around. We're getting some feedback (new issue submissions and whatnot), but not a lot of help, which is unsustainable.
But, we don't know how many individual users we have and how interested they are in marked sticking around.
The plan
Given the possible implications (getting overrun by PRs), a rolling wave approach is proposed:
Ps. For committers, can y'all please start actually putting all merged PRs in the draft release?? I'm guilty myself, to be fair. I think it will help me (and our users) when publishing releases to know what all went into that release and modify marketing and communication language accordingly without having to step through commit and PR history. (Users also get the opportunity to opt-in to the most esoteric details of the release, if they want to.)
Contributor
Committer
In most cases, this should be a different person than the contributor.