-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor docs update for easier maintenance #1116
Minor docs update for easier maintenance #1116
Conversation
Take the burden off the core team to identify which markdown flavor is experiencing the issue.
ps. @styfle has also given really valuable feedback on the docs as they've been coming; so, don't want y'all to think I was saying the criticisms were not warranted nor unwelcome. |
@@ -1,5 +1,7 @@ | |||
**Marked version:** | |||
|
|||
**Markdown flavor:** Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a | |||
|
|||
<!-- The NPM version or commit hash having the issue --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is in the wrong place now. It should be after the Marked Version bold part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated - added change to initial PR comment.
* Add markdown flavors to issues and pr templates Take the burden off the core team to identify which markdown flavor is experiencing the issue. * Add Totally Tron badge * Rename RELEASE to PUBLISHING * Move comment based on review * Rename USAGE_ to USING_
* Add markdown flavors to issues and pr templates Take the burden off the core team to identify which markdown flavor is experiencing the issue. * Add Totally Tron badge * Rename RELEASE to PUBLISHING * Move comment based on review * Rename USAGE_ to USING_
Marked version: 0.3.17
Description
This PR:
Adds Markdown flavor to issues and PR templates: This should reduce our overhead in triaging new issues (if the template isn't followed, it's closed). We should also be able to deprecate the
parser
category of labels (updating the consolidation issues to the new template, if possible).Adds the "Totally Tron" badge to the AUTHORS page: For those who fight for the users (and, just to make sure the base is covered: https://youtu.be/8kcgosLwPDE).
Renames the RELEASE.md to PUBLISHING.md: This keeps our language consistent across the docs compared to AUTHORS.
I'm a contributor - CONTRIBUTING.
A committer - COMMITTING (don't have that yet, maybe @intcreator could help? If you were to be made a committer, what do you think you would need or want to know? The rest of us are all tainted by history; so, you're probably the best person to ask 😃 ).
An Admin - ADMINISTERING (don't have that yet, maybe @styfle and the other committers. Calling @styfle out specifically because he's the resident open source, of course guy, has mentioned the docs might need some work, and so on).
A Publisher - PUBLISHING (instead of RELEASE).
My "position" [noun] matches closely to the documentation for it, which would be better served as a verb, imho. The odd ball is PUBLISHING, because GitHub sets the linguistic standard via CONTRIBUTING being a recognized named file by the application...as opposed to CONTRIBUTE. So, if we went with CONTRIBUTE, GitHub wouldn't recognize it, I don't think...anyway, ELMO-ing myself as pedantic and esoteric.
Renames the USAGE_ to USING_: I'm a user using.
Contributor
Committer
In most cases, this should be a different person than the contributor.