Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor docs update for easier maintenance #1116

Merged
merged 5 commits into from
Mar 4, 2018
Merged

Minor docs update for easier maintenance #1116

merged 5 commits into from
Mar 4, 2018

Conversation

joshbruce
Copy link
Member

@joshbruce joshbruce commented Mar 3, 2018

Marked version: 0.3.17

Description

This PR:

Adds Markdown flavor to issues and PR templates: This should reduce our overhead in triaging new issues (if the template isn't followed, it's closed). We should also be able to deprecate the parser category of labels (updating the consolidation issues to the new template, if possible).

Adds the "Totally Tron" badge to the AUTHORS page: For those who fight for the users (and, just to make sure the base is covered: https://youtu.be/8kcgosLwPDE).

Renames the RELEASE.md to PUBLISHING.md: This keeps our language consistent across the docs compared to AUTHORS.

I'm a contributor - CONTRIBUTING.

A committer - COMMITTING (don't have that yet, maybe @intcreator could help? If you were to be made a committer, what do you think you would need or want to know? The rest of us are all tainted by history; so, you're probably the best person to ask 😃 ).

An Admin - ADMINISTERING (don't have that yet, maybe @styfle and the other committers. Calling @styfle out specifically because he's the resident open source, of course guy, has mentioned the docs might need some work, and so on).

A Publisher - PUBLISHING (instead of RELEASE).

My "position" [noun] matches closely to the documentation for it, which would be better served as a verb, imho. The odd ball is PUBLISHING, because GitHub sets the linguistic standard via CONTRIBUTING being a recognized named file by the application...as opposed to CONTRIBUTE. So, if we went with CONTRIBUTE, GitHub wouldn't recognize it, I don't think...anyway, ELMO-ing myself as pedantic and esoteric.

Renames the USAGE_ to USING_: I'm a user using.

Contributor

  • Test(s) exist to ensure functionality and minimize regresstion (if no tests added, list tests covering this PR); or,
  • no tests required for this PR.
  • If submitting new feature, it has been documented in the appropriate places.

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

Josh Bruce added 3 commits March 3, 2018 11:11
Take the burden off the core team to identify which markdown flavor is experiencing the issue.
@joshbruce
Copy link
Member Author

ps. @styfle has also given really valuable feedback on the docs as they've been coming; so, don't want y'all to think I was saying the criticisms were not warranted nor unwelcome.

@@ -1,5 +1,7 @@
**Marked version:**

**Markdown flavor:** Markdown.pl|CommonMark|GitHub Flavored Markdown|n/a

<!-- The NPM version or commit hash having the issue -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is in the wrong place now. It should be after the Marked Version bold part.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated - added change to initial PR comment.

@styfle styfle merged commit ecbf4b0 into markedjs:master Mar 4, 2018
davisjam pushed a commit to davisjam/marked that referenced this pull request Mar 4, 2018
* Add markdown flavors to issues and pr templates

Take the burden off the core team to identify which markdown flavor is experiencing the issue.

* Add Totally Tron badge

* Rename RELEASE to PUBLISHING

* Move comment based on review

* Rename USAGE_ to USING_
zhenalexfan pushed a commit to zhenalexfan/MarkdownHan that referenced this pull request Nov 8, 2021
* Add markdown flavors to issues and pr templates

Take the burden off the core team to identify which markdown flavor is experiencing the issue.

* Add Totally Tron badge

* Rename RELEASE to PUBLISHING

* Move comment based on review

* Rename USAGE_ to USING_
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants