-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for #1218 & "marked" spec #1219
Conversation
Could we move all of the original tests here? |
@UziTech: Great minds. Once we get this merged in I was going to go ahead and start putting that PR together. One that takes into account that we are doing the CM and GFM comparison separately while trying to maintain backward compatibility awareness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the next PR when moving the original tests here we should also move the Messenger
class to a separate file so we don't have to maintain an implementation in every spec test file
To @UziTech's point, I will see what I can do to put messenger somewhere else...maybe set the options in the spec and have messenger just use whatever is there. Thinking I'll put it in the root of the spec directory - gives me a chance to rename it. |
Test for markedjs#1218 & "marked" spec
Marked version: 0.3.19
Markdown flavor: GitHub Flavored Markdown
Description
Adds test case defining the behavior mentioned in #1218 to ensure we have a test case for it. After looking at the specs, the question does stand, I think, on what the desired output should be when using GFM.
Note: This PR does not submit a solution; only adds to the growing test bed.
Expectation
Result
What was attempted
Contributor
Committer
In most cases, this should be a different person than the contributor.