Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to node 4 syntax #1449

Merged
merged 5 commits into from
Mar 15, 2019
Merged

Update tests to node 4 syntax #1449

merged 5 commits into from
Mar 15, 2019

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Mar 13, 2019

Marked version: master

Description

Update all tests to use html-differ and use syntax for node 4

Contributor

  • Test(s) exist to ensure functionality and minimize regression

Committer

In most cases, this should be a different person than the contributor.

  • Draft GitHub release notes have been updated.
  • CI is green (no forced merge required).
  • Merge PR

}
result.message = 'Expected:\n' + expectedHtml + '\n\nActual:\n' + actualHtml;
const diff = htmlDiffer.firstDiff(actual, expected);
result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result.message = 'Expected: ' + diff.expected + '\n Actual: ' + diff.actual;
result.message = `Expected: ${expected}\nActual: ${actual}`;

test/index.js Outdated
@@ -289,13 +245,13 @@ function runBench(options) {
}
bench('marked (pedantic)', files, marked);

// showdown
// commonmark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove these comments since they are redundant

Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@UziTech UziTech merged commit 6eec528 into markedjs:master Mar 15, 2019
@UziTech UziTech mentioned this pull request Mar 16, 2019
4 tasks
@styfle styfle mentioned this pull request Mar 25, 2019
12 tasks
@UziTech UziTech deleted the use-htmldiffer branch July 1, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants