-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breaks #1507
Fix breaks #1507
Conversation
This fixes the breaks but it adds back the redos in quadradic_br.js when |
This should be released soon since this probably affects a lot of marked users |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what is worse, broken breaks or redos 🤷♂
Let's get this merged. I think fixing a behavior regression is more important than a performance regression. |
Thank you! |
Marked version: 0.6.2
Markdown flavor: GitHub Flavored Markdown with breaks
Description
the
breaks: true
option broke in v0.6.2 because of #1460This reverts the change only when the
breaks
option is set to true.breaks
option (Regression) #1505Contributor
Committer
In most cases, this should be a different person than the contributor.