-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: leave whitespace only lines alone #1889
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/markedjs/markedjs/qnmzg8281 |
@davisjam Could you check these regexps for redos vulnerability?
|
I tried testing those regexes with everything that I could think might cause redos and nothing would cause it so I think they are good. |
## [1.2.8](v1.2.7...v1.2.8) (2021-01-26) ### Bug Fixes * leave whitespace only lines alone ([#1889](#1889)) ([53c79ee](53c79ee))
🎉 This PR is included in version 1.2.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Marked version: v1.2.7
Description
The whitespace is removed from lines with only whitespace. This causes problems in code blocks where the whitespace matters.
This PR keeps the spaces in blank lines and adds them to output.
This PR also adds a new line character to the end of all code blocks.
Contributor
Committer
In most cases, this should be a different person than the contributor.